[GitHub] [carbondata] marchpure opened a new pull request #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition

[GitBox]

marchpure opened a new pull request #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition
URL: https://github.com/apache/carbondata/pull/3590
 
 
    ### Why is this PR needed?
    When drop partition, hive will clean the dictory and data, but carbondata won't, the customers confuse about that. Maybe we should keep same with hive in carbondata.
   
    ### What changes were proposed in this PR?
   When drop partition, set force delete physical partition to true.
   
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition
URL: https://github.com/apache/carbondata/pull/3590#issuecomment-577050925
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1728/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

marchpure commented on issue #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition
URL: https://github.com/apache/carbondata/pull/3590#issuecomment-577052459
 
 
   @jackylk @QiangCai please review
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition
URL: https://github.com/apache/carbondata/pull/3590#issuecomment-577091565
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3590: [CARBONDATA-3669] Delete Physical Partition When Drop Partition
URL: https://github.com/apache/carbondata/pull/3590
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services