[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121838636
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
   
    BytePage does not support unsafeColumnPage ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121838660
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
   
    Byte doe not support unsafeColumnPage ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121839529
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    -    columnPage.byteData = byteData;
    +    columnPage.setBytePage(byteData);
         return columnPage;
       }
     
    -  protected static ColumnPage newShortPage(short[] shortData) {
    -    ColumnPage columnPage = new ColumnPage(SHORT, shortData.length);
    -    columnPage.shortData = shortData;
    +  private static ColumnPage newShortPage(short[] shortData) {
    +    ColumnPage columnPage = createPage(SHORT, shortData.length);
    +    columnPage.setShortPage(shortData);
         return columnPage;
       }
     
    -  protected static ColumnPage newIntPage(int[] intData) {
    -    ColumnPage columnPage = new ColumnPage(INT, intData.length);
    -    columnPage.intData = intData;
    +  private static ColumnPage newIntPage(int[] intData) {
    +    ColumnPage columnPage = createPage(INT, intData.length);
    +    columnPage.setIntPage(intData);
         return columnPage;
       }
     
    -  protected static ColumnPage newLongPage(long[] longData) {
    -    ColumnPage columnPage = new ColumnPage(LONG, longData.length);
    -    columnPage.longData = longData;
    +  private static ColumnPage newLongPage(long[] longData) {
    +    ColumnPage columnPage = createPage(LONG, longData.length);
    +    columnPage.setLongPage(longData);
         return columnPage;
       }
     
    -  protected static ColumnPage newFloatPage(float[] floatData) {
    -    ColumnPage columnPage = new ColumnPage(FLOAT, floatData.length);
    -    columnPage.floatData = floatData;
    +  private static ColumnPage newFloatPage(float[] floatData) {
    +    ColumnPage columnPage = createPage(FLOAT, floatData.length);
    +    columnPage.setFloatPage(floatData);
         return columnPage;
       }
     
    -  protected static ColumnPage newDoublePage(double[] doubleData) {
    -    ColumnPage columnPage = new ColumnPage(DOUBLE, doubleData.length);
    -    columnPage.doubleData = doubleData;
    +  private static ColumnPage newDoublePage(double[] doubleData) {
    +    ColumnPage columnPage = createPage(DOUBLE, doubleData.length);
    +    columnPage.setDoublePage(doubleData);
         return columnPage;
       }
     
    -  protected static ColumnPage newDecimalPage(byte[][] decimalData) {
    -    ColumnPage columnPage = new ColumnPage(DECIMAL, decimalData.length);
    -    columnPage.byteArrayData = decimalData;
    +  private static ColumnPage newDecimalPage(byte[][] decimalData) {
    +    ColumnPage columnPage = createPage(DECIMAL, decimalData.length);
    +    columnPage.setByteArrayPage(decimalData);
         return columnPage;
       }
     
    -  protected static ColumnPage newVarLengthPage(byte[][] stringData) {
    -    ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, stringData.length);
    -    columnPage.byteArrayData = stringData;
    +  private static ColumnPage newVarLengthPage(byte[][] byteArray) {
    +    ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, byteArray.length);
    --- End diff --
   
    ByteArray does not support unsafeColumnPage ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121847432
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor compressor, DataType dataType,
       }
     
       // input byte[] is LV encoded, this function can expand it into byte[][]
    -  private static byte[][] deflatten(byte[] input) {
    +  protected static byte[][] deflatten(byte[] input) {
    --- End diff --
   
    Will it be better to move deflatten to ByteUtil which is same with flatten ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121874665
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
   
    If don't support, we'd better to add some notes to explain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121875823
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor compressor, DataType dataType,
       }
     
       // input byte[] is LV encoded, this function can expand it into byte[][]
    -  private static byte[][] deflatten(byte[] input) {
    +  protected static byte[][] deflatten(byte[] input) {
    --- End diff --
   
    Agree with erlu.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121876896
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -323,15 +340,8 @@ public double getDouble(int rowId) {
         return doubleData[rowId];
       }
     
    -  /**
    -   * Get decimal value at rowId
    -   */
    -  public byte[] getDecimalBytes(int rowId) {
    -    return byteArrayData[rowId];
    -  }
    -
       public BigDecimal getDecimal(int rowId) {
    --- End diff --
   
    Add annotation like getDouble


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user watermen commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121914301
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java ---
    @@ -0,0 +1,321 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +import java.nio.ByteBuffer;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data
    +public class UnsafeColumnPage extends ColumnPage {
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  private static final int byteBits = DataType.BYTE.getSizeBits();
    +  private static final int shortBits = DataType.SHORT.getSizeBits();
    +  private static final int intBits = DataType.INT.getSizeBits();
    +  private static final int longBits = DataType.LONG.getSizeBits();
    +  private static final int floatBits = DataType.FLOAT.getSizeBits();
    +  private static final int doubleBits = DataType.DOUBLE.getSizeBits();
    +
    +  UnsafeColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    switch (dataType) {
    +      case BYTE:
    +      case SHORT:
    +      case INT:
    +      case LONG:
    +      case FLOAT:
    +      case DOUBLE:
    +        int size = pageSize << dataType.getSizeBits();
    +        memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(size);
    +        baseAddress = memoryBlock.getBaseObject();
    +        baseOffset = memoryBlock.getBaseOffset();
    +        break;
    +      case DECIMAL:
    +      case STRING:
    +        byteArrayData = new byte[pageSize][];
    --- End diff --
   
    Why this is not moved to offheap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121928358
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
   
    ok, I will fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121928413
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
   
    ok, it supports, I will fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121928939
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize) {
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    -    columnPage.byteData = byteData;
    +    columnPage.setBytePage(byteData);
         return columnPage;
       }
     
    -  protected static ColumnPage newShortPage(short[] shortData) {
    -    ColumnPage columnPage = new ColumnPage(SHORT, shortData.length);
    -    columnPage.shortData = shortData;
    +  private static ColumnPage newShortPage(short[] shortData) {
    +    ColumnPage columnPage = createPage(SHORT, shortData.length);
    +    columnPage.setShortPage(shortData);
         return columnPage;
       }
     
    -  protected static ColumnPage newIntPage(int[] intData) {
    -    ColumnPage columnPage = new ColumnPage(INT, intData.length);
    -    columnPage.intData = intData;
    +  private static ColumnPage newIntPage(int[] intData) {
    +    ColumnPage columnPage = createPage(INT, intData.length);
    +    columnPage.setIntPage(intData);
         return columnPage;
       }
     
    -  protected static ColumnPage newLongPage(long[] longData) {
    -    ColumnPage columnPage = new ColumnPage(LONG, longData.length);
    -    columnPage.longData = longData;
    +  private static ColumnPage newLongPage(long[] longData) {
    +    ColumnPage columnPage = createPage(LONG, longData.length);
    +    columnPage.setLongPage(longData);
         return columnPage;
       }
     
    -  protected static ColumnPage newFloatPage(float[] floatData) {
    -    ColumnPage columnPage = new ColumnPage(FLOAT, floatData.length);
    -    columnPage.floatData = floatData;
    +  private static ColumnPage newFloatPage(float[] floatData) {
    +    ColumnPage columnPage = createPage(FLOAT, floatData.length);
    +    columnPage.setFloatPage(floatData);
         return columnPage;
       }
     
    -  protected static ColumnPage newDoublePage(double[] doubleData) {
    -    ColumnPage columnPage = new ColumnPage(DOUBLE, doubleData.length);
    -    columnPage.doubleData = doubleData;
    +  private static ColumnPage newDoublePage(double[] doubleData) {
    +    ColumnPage columnPage = createPage(DOUBLE, doubleData.length);
    +    columnPage.setDoublePage(doubleData);
         return columnPage;
       }
     
    -  protected static ColumnPage newDecimalPage(byte[][] decimalData) {
    -    ColumnPage columnPage = new ColumnPage(DECIMAL, decimalData.length);
    -    columnPage.byteArrayData = decimalData;
    +  private static ColumnPage newDecimalPage(byte[][] decimalData) {
    +    ColumnPage columnPage = createPage(DECIMAL, decimalData.length);
    +    columnPage.setByteArrayPage(decimalData);
         return columnPage;
       }
     
    -  protected static ColumnPage newVarLengthPage(byte[][] stringData) {
    -    ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, stringData.length);
    -    columnPage.byteArrayData = stringData;
    +  private static ColumnPage newVarLengthPage(byte[][] byteArray) {
    +    ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, byteArray.length);
    --- End diff --
   
    It supports, I will update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121928967
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor compressor, DataType dataType,
       }
     
       // input byte[] is LV encoded, this function can expand it into byte[][]
    -  private static byte[][] deflatten(byte[] input) {
    +  protected static byte[][] deflatten(byte[] input) {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121930114
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -323,15 +340,8 @@ public double getDouble(int rowId) {
         return doubleData[rowId];
       }
     
    -  /**
    -   * Get decimal value at rowId
    -   */
    -  public byte[] getDecimalBytes(int rowId) {
    -    return byteArrayData[rowId];
    -  }
    -
       public BigDecimal getDecimal(int rowId) {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121930195
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java ---
    @@ -0,0 +1,321 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +import java.nio.ByteBuffer;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data
    +public class UnsafeColumnPage extends ColumnPage {
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  private static final int byteBits = DataType.BYTE.getSizeBits();
    +  private static final int shortBits = DataType.SHORT.getSizeBits();
    +  private static final int intBits = DataType.INT.getSizeBits();
    +  private static final int longBits = DataType.LONG.getSizeBits();
    +  private static final int floatBits = DataType.FLOAT.getSizeBits();
    +  private static final int doubleBits = DataType.DOUBLE.getSizeBits();
    +
    +  UnsafeColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    switch (dataType) {
    +      case BYTE:
    +      case SHORT:
    +      case INT:
    +      case LONG:
    +      case FLOAT:
    +      case DOUBLE:
    +        int size = pageSize << dataType.getSizeBits();
    +        memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(size);
    +        baseAddress = memoryBlock.getBaseObject();
    +        baseOffset = memoryBlock.getBaseOffset();
    +        break;
    +      case DECIMAL:
    +      case STRING:
    +        byteArrayData = new byte[pageSize][];
    --- End diff --
   
    I updated this PR, now all types are unsafe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2481/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/366/<h2>Failed Tests: <span class='status-failure'>2</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/366/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>2</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/366/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.bigdecimal/TestNullAndEmptyFields/test_filter_query_on_column_is_null/'><strong>org.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is null</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/366/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondat
 a.spark.testsuite.bigdecimal/TestNullAndEmptyFields/test_filter_query_on_column_is_not_null/'><strong>org.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is not null</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121932974
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    --- End diff --
   
    how about the data which is stored in old memory block,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121933673
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    --- End diff --
   
    In C/C++ world, old data should be copied to the reallocated address.
    http://en.cppreference.com/w/c/memory/realloc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121934356
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    --- End diff --
   
    it is inefficient to put data byte by byte, use `copyMemory` method



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---