[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121934452
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    +    }
    +    rowOffset[rowId] = offset + bytes.length + 4;
    +    totolLength += bytes.length;
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    int currentRowOffset = rowOffset[rowId];
    +    for (int i = 0; i < length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + currentRowOffset + i, bytes[i]);
    +    }
    +  }
    +
    +  @Override
    +  public BigDecimal getDecimal(int rowId) {
    +    int offset, length;
    +    if (rowId == 0) {
    +      length = rowOffset[rowId];
    +      offset = 0;
    +    } else {
    +      length = rowOffset[rowId] - rowOffset[rowId - 1];
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    byte[] bytes = new byte[length];
    +    for (int i = 0; i < length; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + i);
    +    }
    +
    +    return DataTypeUtil.byteToBigDecimal(bytes);
    +  }
    +
    +  @Override
    +  public byte[][] getByteArrayPage() {
    +    byte[][] bytes = new byte[pageSize][];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      int offset, length;
    +      if (rowId == 0) {
    +        length = rowOffset[rowId] - 4;
    +        offset = 0;
    +      } else {
    +        length = rowOffset[rowId] - rowOffset[rowId - 1] - 4;
    +        offset = rowOffset[rowId - 1];
    +      }
    +      byte[] rowData = new byte[length];
    +      for (int j = 0; j < length; j++) {
    +        rowData[j] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + j);
    --- End diff --
   
    even for copying also please `copyMemory`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121934575
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    +    }
    +    rowOffset[rowId] = offset + bytes.length + 4;
    +    totolLength += bytes.length;
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    int currentRowOffset = rowOffset[rowId];
    +    for (int i = 0; i < length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + currentRowOffset + i, bytes[i]);
    +    }
    +  }
    +
    +  @Override
    +  public BigDecimal getDecimal(int rowId) {
    +    int offset, length;
    +    if (rowId == 0) {
    +      length = rowOffset[rowId];
    +      offset = 0;
    +    } else {
    +      length = rowOffset[rowId] - rowOffset[rowId - 1];
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    byte[] bytes = new byte[length];
    +    for (int i = 0; i < length; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + i);
    +    }
    +
    +    return DataTypeUtil.byteToBigDecimal(bytes);
    +  }
    +
    +  @Override
    +  public byte[][] getByteArrayPage() {
    +    byte[][] bytes = new byte[pageSize][];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      int offset, length;
    +      if (rowId == 0) {
    +        length = rowOffset[rowId] - 4;
    +        offset = 0;
    +      } else {
    +        length = rowOffset[rowId] - rowOffset[rowId - 1] - 4;
    +        offset = rowOffset[rowId - 1];
    +      }
    +      byte[] rowData = new byte[length];
    +      for (int j = 0; j < length; j++) {
    +        rowData[j] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + j);
    +      }
    +      bytes[rowId] = rowData;
    +    }
    +    return bytes;
    +  }
    +
    +  @Override
    +  public byte[] getFlattenedBytePage() {
    +    byte[] bytes = new byte[totolLength];
    +    for (int i = 0; i < totolLength; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + i);
    --- End diff --
   
    use `copyMemory`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121937156
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121937162
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    +    }
    +    rowOffset[rowId] = offset + bytes.length + 4;
    +    totolLength += bytes.length;
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    int currentRowOffset = rowOffset[rowId];
    +    for (int i = 0; i < length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + currentRowOffset + i, bytes[i]);
    +    }
    +  }
    +
    +  @Override
    +  public BigDecimal getDecimal(int rowId) {
    +    int offset, length;
    +    if (rowId == 0) {
    +      length = rowOffset[rowId];
    +      offset = 0;
    +    } else {
    +      length = rowOffset[rowId] - rowOffset[rowId - 1];
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    byte[] bytes = new byte[length];
    +    for (int i = 0; i < length; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + i);
    +    }
    +
    +    return DataTypeUtil.byteToBigDecimal(bytes);
    +  }
    +
    +  @Override
    +  public byte[][] getByteArrayPage() {
    +    byte[][] bytes = new byte[pageSize][];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      int offset, length;
    +      if (rowId == 0) {
    +        length = rowOffset[rowId] - 4;
    +        offset = 0;
    +      } else {
    +        length = rowOffset[rowId] - rowOffset[rowId - 1] - 4;
    +        offset = rowOffset[rowId - 1];
    +      }
    +      byte[] rowData = new byte[length];
    +      for (int j = 0; j < length; j++) {
    +        rowData[j] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + j);
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121937358
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -0,0 +1,212 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +
    +import static org.apache.carbondata.core.metadata.datatype.DataType.DECIMAL;
    +
    +public abstract class VarLengthColumnPageBase extends ColumnPage {
    +
    +  // the offset of row whose id is (N + 1) in the unsafe memory
    +  // for example, if first two rows are 8 bytes and 4 bytes, then rowOffset[0] == 8,
    +  // and rowOffset[1] == 12
    +  int[] rowOffset;
    +
    +  // the length of bytes added in the page
    +  int totolLength;
    +
    +  VarLengthColumnPageBase(DataType dataType, int pageSize) {
    +    super(dataType, pageSize);
    +  }
    +
    +  @Override
    +  public void setBytePage(byte[] byteData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setShortPage(short[] shortData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setIntPage(int[] intData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setLongPage(long[] longData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setFloatPage(float[] floatData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setDoublePage(double[] doubleData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setByteArrayPage(byte[][] byteArray) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  /**
    +   * Create a new column page based on the LV (Length Value) encoded bytes
    +   */
    +  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes) throws MemoryException {
    +    // extract length and data, set them to rowOffset and unsafe memory correspondingly
    +    int rowId = 0;
    +    List<Integer> rowOffset = new ArrayList<>();
    +    List<Integer> rowLength = new ArrayList<>();
    +    int length;
    +    int offset = 0;
    +    int nextRowOffset;
    +
    +    // extract Length field in input and calculate total length
    +    for (offset = 0; offset < lvEncodedBytes.length; offset = nextRowOffset) {
    +      length = (((int)lvEncodedBytes[offset]) << 24) + (((int)lvEncodedBytes[offset + 1]) << 16) +
    --- End diff --
   
    why don't use `Byteutil.toInt`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121938987
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes) {
    +    int offset;
    +    if (rowId == 0) {
    +      offset = 0;
    +    } else {
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    for (int i = 0; i < bytes.length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i, bytes[i]);
    +    }
    +    rowOffset[rowId] = offset + bytes.length + 4;
    +    totolLength += bytes.length;
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    int currentRowOffset = rowOffset[rowId];
    +    for (int i = 0; i < length; i++) {
    +      CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + currentRowOffset + i, bytes[i]);
    +    }
    +  }
    +
    +  @Override
    +  public BigDecimal getDecimal(int rowId) {
    +    int offset, length;
    +    if (rowId == 0) {
    +      length = rowOffset[rowId];
    +      offset = 0;
    +    } else {
    +      length = rowOffset[rowId] - rowOffset[rowId - 1];
    +      offset = rowOffset[rowId - 1];
    +    }
    +
    +    byte[] bytes = new byte[length];
    +    for (int i = 0; i < length; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + i);
    +    }
    +
    +    return DataTypeUtil.byteToBigDecimal(bytes);
    +  }
    +
    +  @Override
    +  public byte[][] getByteArrayPage() {
    +    byte[][] bytes = new byte[pageSize][];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      int offset, length;
    +      if (rowId == 0) {
    +        length = rowOffset[rowId] - 4;
    +        offset = 0;
    +      } else {
    +        length = rowOffset[rowId] - rowOffset[rowId - 1] - 4;
    +        offset = rowOffset[rowId - 1];
    +      }
    +      byte[] rowData = new byte[length];
    +      for (int j = 0; j < length; j++) {
    +        rowData[j] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + offset + j);
    +      }
    +      bytes[rowId] = rowData;
    +    }
    +    return bytes;
    +  }
    +
    +  @Override
    +  public byte[] getFlattenedBytePage() {
    +    byte[] bytes = new byte[totolLength];
    +    for (int i = 0; i < totolLength; i++) {
    +      bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset + i);
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121939570
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    --- End diff --
   
    isn't it it should be like `UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, totolLength+requestSize)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121939849
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    --- End diff --
   
    actually we may allocate capacity + capacity *0.25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121940029
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -0,0 +1,212 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +
    +import static org.apache.carbondata.core.metadata.datatype.DataType.DECIMAL;
    +
    +public abstract class VarLengthColumnPageBase extends ColumnPage {
    +
    +  // the offset of row whose id is (N + 1) in the unsafe memory
    +  // for example, if first two rows are 8 bytes and 4 bytes, then rowOffset[0] == 8,
    +  // and rowOffset[1] == 12
    +  int[] rowOffset;
    +
    +  // the length of bytes added in the page
    +  int totolLength;
    +
    +  VarLengthColumnPageBase(DataType dataType, int pageSize) {
    +    super(dataType, pageSize);
    +  }
    +
    +  @Override
    +  public void setBytePage(byte[] byteData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setShortPage(short[] shortData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setIntPage(int[] intData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setLongPage(long[] longData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setFloatPage(float[] floatData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setDoublePage(double[] doubleData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setByteArrayPage(byte[][] byteArray) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  /**
    +   * Create a new column page based on the LV (Length Value) encoded bytes
    +   */
    +  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes) throws MemoryException {
    +    // extract length and data, set them to rowOffset and unsafe memory correspondingly
    +    int rowId = 0;
    +    List<Integer> rowOffset = new ArrayList<>();
    +    List<Integer> rowLength = new ArrayList<>();
    +    int length;
    +    int offset = 0;
    +    int nextRowOffset;
    +
    +    // extract Length field in input and calculate total length
    +    for (offset = 0; offset < lvEncodedBytes.length; offset = nextRowOffset) {
    +      length = (((int)lvEncodedBytes[offset]) << 24) + (((int)lvEncodedBytes[offset + 1]) << 16) +
    --- End diff --
   
    `ByteUtil.toInt` internal is using Unsafe, which it is wrong in this context


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121940121
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +    rowOffset = new int[pageSize];
    +    totolLength = 0;
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totolLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
    +    }
    --- End diff --
   
    yes, I will modify


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121940556
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -0,0 +1,212 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +
    +import static org.apache.carbondata.core.metadata.datatype.DataType.DECIMAL;
    +
    +public abstract class VarLengthColumnPageBase extends ColumnPage {
    +
    +  // the offset of row whose id is (N + 1) in the unsafe memory
    +  // for example, if first two rows are 8 bytes and 4 bytes, then rowOffset[0] == 8,
    +  // and rowOffset[1] == 12
    +  int[] rowOffset;
    +
    +  // the length of bytes added in the page
    +  int totolLength;
    +
    +  VarLengthColumnPageBase(DataType dataType, int pageSize) {
    +    super(dataType, pageSize);
    +  }
    +
    +  @Override
    +  public void setBytePage(byte[] byteData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setShortPage(short[] shortData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setIntPage(int[] intData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setLongPage(long[] longData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setFloatPage(float[] floatData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setDoublePage(double[] doubleData) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  @Override
    +  public void setByteArrayPage(byte[][] byteArray) {
    +    throw new UnsupportedOperationException("invalid data type: " + dataType);
    +  }
    +
    +  /**
    +   * Create a new column page based on the LV (Length Value) encoded bytes
    +   */
    +  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes) throws MemoryException {
    +    // extract length and data, set them to rowOffset and unsafe memory correspondingly
    +    int rowId = 0;
    +    List<Integer> rowOffset = new ArrayList<>();
    +    List<Integer> rowLength = new ArrayList<>();
    +    int length;
    +    int offset = 0;
    +    int nextRowOffset;
    +
    +    // extract Length field in input and calculate total length
    +    for (offset = 0; offset < lvEncodedBytes.length; offset = nextRowOffset) {
    +      length = (((int)lvEncodedBytes[offset]) << 24) + (((int)lvEncodedBytes[offset + 1]) << 16) +
    --- End diff --
   
    then you can one more method in ByteUtil with out unsafe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2486/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2487/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/371/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/371/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/371/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.bigdecimal/TestDimensionWithDecimalDataType/test_unsafe_with_bigdecimal/'><strong>org.apache.carbondata.spark.testsuite.bigdecimal.TestDimensionWithDecimalDataType.test unsafe with bigdecimal</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/372/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/372/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/372/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.bigdecimal/TestDimensionWithDecimalDataType/test_unsafe_with_bigdecimal/'><strong>org.apache.carbondata.spark.testsuite.bigdecimal.TestDimensionWithDecimalDataType.test unsafe with bigdecimal</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r122114396
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  private static final double FACTOR = 1.25;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry((long)(capacity * FACTOR));
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +      memoryBlock = null;
    +      baseAddress = null;
    +      baseOffset = 0;
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totalLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(
    +          memoryBlock, (long)((totalLength + requestSize) * FACTOR));
    --- End diff --
   
    `capacity` should be updated with `(totalLength + requestSize) * FACTOR`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r122116031
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  private static final double FACTOR = 1.25;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry((long)(capacity * FACTOR));
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +      memoryBlock = null;
    +      baseAddress = null;
    +      baseOffset = 0;
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totalLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(
    +          memoryBlock, (long)((totalLength + requestSize) * FACTOR));
    +      baseAddress = memoryBlock.getBaseObject();
    +      baseOffset = memoryBlock.getBaseOffset();
    +    }
    +  }
    +
    +  @Override
    +  public void putBytesAtRow(int rowId, byte[] bytes) {
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    CarbonUnsafe.unsafe.copyMemory(bytes, CarbonUnsafe.BYTE_ARRAY_OFFSET,
    +        baseAddress, baseOffset + rowOffset[rowId], bytes.length);
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    CarbonUnsafe.unsafe.copyMemory(bytes, CarbonUnsafe.BYTE_ARRAY_OFFSET + offset,
    +        baseAddress, baseOffset + rowOffset[rowId], length);
    +  }
    +
    --- End diff --
   
    Even method `public void putBytes(int rowId, byte[] bytes)` also need to be override here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r122123190
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  private static final double FACTOR = 1.25;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry((long)(capacity * FACTOR));
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +      memoryBlock = null;
    +      baseAddress = null;
    +      baseOffset = 0;
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totalLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(
    +          memoryBlock, (long)((totalLength + requestSize) * FACTOR));
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r122123309
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  private static final double FACTOR = 1.25;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry((long)(capacity * FACTOR));
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +      memoryBlock = null;
    +      baseAddress = null;
    +      baseOffset = 0;
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totalLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(
    +          memoryBlock, (long)((totalLength + requestSize) * FACTOR));
    +      baseAddress = memoryBlock.getBaseObject();
    +      baseOffset = memoryBlock.getBaseOffset();
    +    }
    +  }
    +
    +  @Override
    +  public void putBytesAtRow(int rowId, byte[] bytes) {
    +    try {
    +      ensureMemory(bytes.length);
    +    } catch (MemoryException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    CarbonUnsafe.unsafe.copyMemory(bytes, CarbonUnsafe.BYTE_ARRAY_OFFSET,
    +        baseAddress, baseOffset + rowOffset[rowId], bytes.length);
    +  }
    +
    +  @Override
    +  public void putBytes(int rowId, byte[] bytes, int offset, int length) {
    +    CarbonUnsafe.unsafe.copyMemory(bytes, CarbonUnsafe.BYTE_ARRAY_OFFSET + offset,
    +        baseAddress, baseOffset + rowOffset[rowId], length);
    +  }
    +
    --- End diff --
   
    It is implemented in `VarLengthColumnPageBase` and it will call `putBytesAtRow`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1000
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2491/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---