[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
GitHub user chenliang613 opened a pull request:

    https://github.com/apache/carbondata/pull/1162

    [CARBONDATA-1295] Optimize test cases,merge three QueryTest class into one

    Optimize test cases,merge three QueryTest class into one, and update related code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/carbondata opti_testcase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1162
   
----
commit b2740f1e3f3e3bbd2ce29794a8adb45c7e96a9a0
Author: chenliang613 <[hidden email]>
Date:   2017-07-12T02:45:22Z

    [CARBONDATA-1295] Optimize test cases,merge three QueryTest class into one

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/440/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3028/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1162#discussion_r126870955
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.common.util
    +
    +import org.apache.spark.sql.hive.CarbonSessionState
    +import org.apache.spark.sql.test.util.QueryTest
    +
    +
    +class Spark2QueryTest extends QueryTest {
    +
    +  val hiveClient = sqlContext.sparkSession.sessionState.asInstanceOf[CarbonSessionState]
    +    .metadataHive
    +
    +  protected def createAndLoadInputTable(inputTableName: String, inputPath: String): Unit = {
    --- End diff --
   
    Please remove this method from here, it should be in respective testcase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1162#discussion_r126870976
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.common.util
    +
    +import org.apache.spark.sql.hive.CarbonSessionState
    +import org.apache.spark.sql.test.util.QueryTest
    +
    +
    +class Spark2QueryTest extends QueryTest {
    +
    +  val hiveClient = sqlContext.sparkSession.sessionState.asInstanceOf[CarbonSessionState]
    +    .metadataHive
    +
    +  protected def createAndLoadInputTable(inputTableName: String, inputPath: String): Unit = {
    +    sql(
    +      s"""
    +         | CREATE TABLE $inputTableName
    +         | (  shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField string,
    +         |    decimalField decimal(18,2),
    +         |    dateField string,
    +         |    charField char(5)
    +         | )
    +         | ROW FORMAT DELIMITED FIELDS TERMINATED BY ','
    +       """.stripMargin)
    +
    +    sql(
    +      s"""
    +         | LOAD DATA LOCAL INPATH '$inputPath'
    +         | INTO TABLE $inputTableName
    +       """.stripMargin)
    +  }
    +
    +  protected def createAndLoadTestTable(tableName: String, inputTableName: String): Unit = {
    --- End diff --
   
    Please remove this method from here, it should be in respective testcase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1162#discussion_r126872523
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.common.util
    +
    +import org.apache.spark.sql.hive.CarbonSessionState
    +import org.apache.spark.sql.test.util.QueryTest
    +
    +
    +class Spark2QueryTest extends QueryTest {
    +
    +  val hiveClient = sqlContext.sparkSession.sessionState.asInstanceOf[CarbonSessionState]
    +    .metadataHive
    +
    +  protected def createAndLoadInputTable(inputTableName: String, inputPath: String): Unit = {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1162#discussion_r126872536
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.common.util
    +
    +import org.apache.spark.sql.hive.CarbonSessionState
    +import org.apache.spark.sql.test.util.QueryTest
    +
    +
    +class Spark2QueryTest extends QueryTest {
    +
    +  val hiveClient = sqlContext.sparkSession.sessionState.asInstanceOf[CarbonSessionState]
    +    .metadataHive
    +
    +  protected def createAndLoadInputTable(inputTableName: String, inputPath: String): Unit = {
    +    sql(
    +      s"""
    +         | CREATE TABLE $inputTableName
    +         | (  shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField string,
    +         |    decimalField decimal(18,2),
    +         |    dateField string,
    +         |    charField char(5)
    +         | )
    +         | ROW FORMAT DELIMITED FIELDS TERMINATED BY ','
    +       """.stripMargin)
    +
    +    sql(
    +      s"""
    +         | LOAD DATA LOCAL INPATH '$inputPath'
    +         | INTO TABLE $inputTableName
    +       """.stripMargin)
    +  }
    +
    +  protected def createAndLoadTestTable(tableName: String, inputTableName: String): Unit = {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/444/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3032/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1162: [CARBONDATA-1295] Optimize test cases,merge three Qu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1162
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---