[GitHub] carbondata pull request #1273: [CARBONDATA-1400] Fix bug of array column out...

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138517320
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -79,29 +82,29 @@ public void setDoublePage(double[] doubleData) {
       /**
        * Create a new column page for decimal page
        */
    -  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes, int scale, int precision)
    -      throws MemoryException {
    +  static ColumnPage newDecimalColumnPage(TableSpec.ColumnSpec columnSpec, byte[] lvEncodedBytes,
    +      int scale, int precision) throws MemoryException {
    --- End diff --
   
    since columnSpec is passed can we remove scala and precision from methods and get from columnspec?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138518349
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -79,29 +82,29 @@ public void setDoublePage(double[] doubleData) {
       /**
        * Create a new column page for decimal page
        */
    -  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes, int scale, int precision)
    -      throws MemoryException {
    +  static ColumnPage newDecimalColumnPage(TableSpec.ColumnSpec columnSpec, byte[] lvEncodedBytes,
    +      int scale, int precision) throws MemoryException {
    --- End diff --
   
    I will try it


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138518998
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -79,29 +82,29 @@ public void setDoublePage(double[] doubleData) {
       /**
        * Create a new column page for decimal page
        */
    -  static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes, int scale, int precision)
    -      throws MemoryException {
    +  static ColumnPage newDecimalColumnPage(TableSpec.ColumnSpec columnSpec, byte[] lvEncodedBytes,
    +      int scale, int precision) throws MemoryException {
    --- End diff --
   
    I will try, but it is a temporary solution.
    I think the correct way is to make DataType a class instead of enum, and keep precision and scale in that.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/724/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/98/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/99/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    @jackylk it seems compilation fails after rebase to master. please check once


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/4/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/5/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/103/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1273


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/725/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/731/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/730/



---