[GitHub] carbondata pull request #1273: [CARBONDATA-1400] Fix bug of array column out...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1273

    [CARBONDATA-1400] Fix bug of array column out of bound when writing carbondata file

    If there is a big array in input csv file, when loading carbondata table, it may throw ArrayIndexOutOfBoundException
   
    This PR fixed it by changing complex column encoding to DirectCompressionEncoding
    This PR added a test case to test input data with big array
   
    This PR is based on #1265

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata complex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1273
   
----
commit 3b22da9a38856b70cb54516ded3113e6cd68a7b2
Author: Jacky Li <[hidden email]>
Date:   2017-08-18T06:48:09Z

    decode by meta

commit 16441766ae726e7eee14ea2e313861f4a1440236
Author: Jacky Li <[hidden email]>
Date:   2017-08-19T02:41:17Z

    add direct string encoding

commit f296c389e7f9492cd2e186c7d03859000aec1ce3
Author: Jacky Li <[hidden email]>
Date:   2017-08-19T18:17:43Z

    fix big array bug

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/265/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/268/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/273/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/310/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/677/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/680/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/684/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/685/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/686/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/688/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138262250
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java ---
    @@ -67,6 +70,17 @@ public void setByteArrayPage(byte[][] byteArray) {
       }
     
       @Override
    +  public byte[] getLVFlattenedBytePage() throws IOException {
    +    ByteArrayOutputStream stream = new ByteArrayOutputStream();
    +    DataOutputStream out = new DataOutputStream(stream);
    +    for (byte[] byteArrayDatum : byteArrayData) {
    +      out.writeInt(byteArrayDatum.length);
    --- End diff --
   
    can' t we use short here?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    @jackylk  tests are failing in 1.6, please check


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1273#discussion_r138330052
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java ---
    @@ -67,6 +70,17 @@ public void setByteArrayPage(byte[][] byteArray) {
       }
     
       @Override
    +  public byte[] getLVFlattenedBytePage() throws IOException {
    +    ByteArrayOutputStream stream = new ByteArrayOutputStream();
    +    DataOutputStream out = new DataOutputStream(stream);
    +    for (byte[] byteArrayDatum : byteArrayData) {
    +      out.writeInt(byteArrayDatum.length);
    --- End diff --
   
    This is for backward compatible, old code use 4 bytes to store length


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/711/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/713/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/717/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1273
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/22/



---