Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1299: [CARBONDATA-1426] Resolved Split Partition Bu...

Classic

List

Threaded

11 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1299: [CARBONDATA-1426] Resolved Split Partition Bu...

GitHub user nehabhardwaj01 opened a pull request:

https://github.com/apache/carbondata/pull/1299

[CARBONDATA-1426] Resolved Split Partition Bug When NewList sequence is different from OldList

Split Partition Raises Exception when the sequence of NewList Elements differ from OldList Elements.
The PR is for this bug.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nehabhardwaj01/incubator-carbondata resolve/CARBONDATA-1426

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1299

----
commit 9af01abebe1e9b2d59dc1e9e0fb51e1ee60f2f03
Author: nehabhardwaj01 <[hidden email]>
Date: 2017-08-30T09:59:36Z

Resolved Split Partition Bug When NewList sequence is different from OldList

----

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

qiuchenjian-2

[GitHub] carbondata pull request #1299: [CARBONDATA-1426] Resolved Split Partition Bu...

Github user xuchuanyin commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1299#discussion_r136105752

--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -351,7 +351,7 @@ object CommonUtil {
if (tempList.length != originListInfo.size) {
sys.error("The total number of elements in new list must equal to original list!")
}
- if (!originListInfo.sameElements(tempList)) {
+ if (originListInfo.toSet!=tempList.toSet) {
--- End diff --

According to the error message below, it requires `originListInfo` contains `tempList`, so the condition should be like `!(tempList diff originListInfo).isEmpty`

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

qiuchenjian-2