[GitHub] carbondata pull request #1310: [CARBONDATA-1442] Refactored Partition-Guide....

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1310: [CARBONDATA-1442] Refactored Partition-Guide....

qiuchenjian-2
GitHub user jatin9896 opened a pull request:

    https://github.com/apache/carbondata/pull/1310

    [CARBONDATA-1442] Refactored Partition-Guide.md

    Refactored the partition-guide.md file to maintain consistency of headings across the all the doc files and formatted the syntax to generate correct pdf for the carbondata website.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jatin9896/incubator-carbondata docs/ReformatPartitionGuide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1310
   
----
commit ca24013b704fa931c7d2b287ec8b520ae7ffc5f8
Author: jatin9896 <[hidden email]>
Date:   2017-08-31T06:14:36Z

    Refactored partition-guide

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
Github user PallaviSingh1992 commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    @sgururajshetty @chenliang613 please review this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Ayushi93 commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    LGTM
    @chenliang613 kindly review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    LGTM
    @chenliang613  kindly review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    It seems this PR contains some commit from master. Can you rebase and squash your commit? @jatin9896


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user Ayushi93 commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    I shall be doing it today by EOD.
   
    On 06-Sep-2017 7:33 PM, "Jacky Li" <[hidden email]> wrote:
   
    It seems this PR contains some commit from master. Can you rebase and
    squash your commit? @jatin9896 <https://github.com/jatin9896>
   
    —
    You are receiving this because you commented.
    Reply to this email directly, view it on GitHub
    <https://github.com/apache/carbondata/pull/1310#issuecomment-327493321>,
    or mute
    the thread
    <https://github.com/notifications/unsubscribe-auth/Ady6ZrYgvS4F42JXqe2lEeP45eIOku9Hks5sfqZDgaJpZM4PIyhj>
    .



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user PallaviSingh1992 commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    @jackylk I have squashed the commits


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/587/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1310: [CARBONDATA-1442] Refactored Partition-Guide.md

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1310
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1310: [CARBONDATA-1442] Refactored Partition-Guide....

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1310


---