[GitHub] carbondata pull request #1334: [CARBONDATA-1451] Removing configuration for ...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1334

    [CARBONDATA-1451] Removing configuration for number_of_rows_per_blocklet_column_page

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata page_rows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1334
   
----
commit c3b530bd709acd922a9ec907ec57fa0bfd745c9b
Author: dhatchayani <[hidden email]>
Date:   2017-09-06T09:55:33Z

    [CARBONDATA-1451] Removing configuration for number_of_rows_per_blocklet_column_page

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1334
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/563/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1334#discussion_r137255098
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonV3DataFormatConstants.java ---
    @@ -61,24 +61,8 @@
       short NUMBER_OF_COLUMN_TO_READ_IN_IO_MIN = 1;
     
       /**
    -   * number of rows per blocklet column page
    -   */
    -  @CarbonProperty
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE = "number.of.rows.per.blocklet.column.page";
    -
    -  /**
        * number of rows per blocklet column page default value
        */
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = "32000";
    -
    -  /**
    -   * number of rows per blocklet column page max value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MAX = 32000;
    -
    -  /**
    -   * number of rows per blocklet column page min value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MIN = 8000;
    +  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = 32000;
    --- End diff --
   
    I do not think it is configurable, better to remove it from this file


---

[qiuchenjian-2]

Github user dhatchayani commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1334#discussion_r137450091
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonV3DataFormatConstants.java ---
    @@ -61,24 +61,8 @@
       short NUMBER_OF_COLUMN_TO_READ_IN_IO_MIN = 1;
     
       /**
    -   * number of rows per blocklet column page
    -   */
    -  @CarbonProperty
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE = "number.of.rows.per.blocklet.column.page";
    -
    -  /**
        * number of rows per blocklet column page default value
        */
    -  String NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = "32000";
    -
    -  /**
    -   * number of rows per blocklet column page max value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MAX = 32000;
    -
    -  /**
    -   * number of rows per blocklet column page min value
    -   */
    -  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_MIN = 8000;
    +  short NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT = 32000;
    --- End diff --
   
    this is not configurable. 32000 is the default constant stored as "NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT"


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1334
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1334


---