[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/174/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/50/



---

[qiuchenjian-2]

Github user mayunSaicmotor commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/52/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/176/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/804/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/806/



---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r139282418
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
    @@ -36,7 +36,8 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
     
       override def beforeAll {
         dropTable
    -
    +    CarbonProperties.getInstance()
    --- End diff --
   
    Reset this property in afterall


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r139282463
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
    @@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
         checkAnswer(result_after5, result_origin5)
       }
     
    +   test("test exception when alter partition and the values"
    --- End diff --
   
    Multiple tests under single test definition.split it into multiple


---

[qiuchenjian-2]

Github user mayunSaicmotor commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r139284844
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
    @@ -36,7 +36,8 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
     
       override def beforeAll {
         dropTable
    -
    +    CarbonProperties.getInstance()
    --- End diff --
   
    added


---

[qiuchenjian-2]

Github user mayunSaicmotor commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r139285031
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
    @@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
         checkAnswer(result_after5, result_origin5)
       }
     
    +   test("test exception when alter partition and the values"
    --- End diff --
   
    actually I refer to carbondata-spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestDDLForPartitionTable.scala. All the new added test cases are belong to the same type.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/62/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/186/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/817/



---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r139307125
 
    --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
    @@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
         checkAnswer(result_after5, result_origin5)
       }
     
    +   test("test exception when alter partition and the values"
    --- End diff --
   
    That is also wrong.you can rework both and split into multiple test cases in another pr


---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1336


---