[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...

[qiuchenjian-2]

GitHub user mayunSaicmotor opened a pull request:

    https://github.com/apache/carbondata/pull/1336

    [CARBONDATA-1425] Inappropriate Exception displays while creating a new partition with incorrect partition type

    change the error content when the range info data mismatch the partition field's data type  
    the new  showing content as below:
   
    "Data in range info must be the same type with the partition field's type"
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1425

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1336
   
----
commit c3d0debdaff3edeb67b6fb1f01f6dbfdda9a9b8a
Author: mayun <[hidden email]>
Date:   2017-09-06T14:52:39Z

    fix for  carbondata 1425

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/579/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/583/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/584/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/591/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7/



---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1336#discussion_r138555709
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/partition/PartitionUtil.java ---
    @@ -71,6 +72,10 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
             default:
               return data;
           }
    +    } catch (NumberFormatException ex) {
    +      return new IllegalArgumentException(ex.getMessage());
    --- End diff --
   
    can throw MalformedCarbonException instead of runtime.
    Its not good coding practice to return the exception object instead of throwing it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/111/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/11/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/737/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/776/



---

[qiuchenjian-2]

Github user QACarbonData commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/151/



---

[qiuchenjian-2]

Github user QACarbonData commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/30/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/169/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/46/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/799/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1336
 
    retest this please


---