[GitHub] carbondata pull request #1357: [CARBONDATA-1372]update compaction documentat...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1357

    [CARBONDATA-1372]update compaction documentation

    In order to easier to understand, update the description about compaction.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata compaction_doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1357
   
----
commit 5601ddd3360fb18ed1cc6e47f71b0cd8db2a88b7
Author: xubo245 <[hidden email]>
Date:   2017-09-13T12:24:40Z

    update compaction documentation

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1357
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/107/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1357
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/8/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1357
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/734/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1357#discussion_r138835309
 
    --- Diff: docs/data-management.md ---
    @@ -135,7 +135,7 @@ CLEAN FILES FOR TABLE table1
       
     | Parameter | Default | Application | Description | Valid Values |
     |-----------------------------------------|---------|-------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------|
    -| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3 then minor compaction will be triggered for every 2 segments. 3 is the number of level 1 compacted segment which is further compacted to new segment. | NA |
    +| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3, then minor compaction will be triggered for every 2 segments in level 1. 3 is the number of level 1 compacted segment which is further compacted to new segment in level 2. | NA |
    --- End diff --
   
    suggest to change `2, 3` to `"2, 3"`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1357#discussion_r138835646
 
    --- Diff: docs/data-management.md ---
    @@ -135,7 +135,7 @@ CLEAN FILES FOR TABLE table1
       
     | Parameter | Default | Application | Description | Valid Values |
     |-----------------------------------------|---------|-------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------|
    -| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3 then minor compaction will be triggered for every 2 segments. 3 is the number of level 1 compacted segment which is further compacted to new segment. | NA |
    +| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3, then minor compaction will be triggered for every 2 segments in level 1. 3 is the number of level 1 compacted segment which is further compacted to new segment in level 2. | NA |
    --- End diff --
   
    suggest to explain level 1 compaction and level 2 compaction first.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1357#discussion_r139051979
 
    --- Diff: docs/data-management.md ---
    @@ -135,7 +135,7 @@ CLEAN FILES FOR TABLE table1
       
     | Parameter | Default | Application | Description | Valid Values |
     |-----------------------------------------|---------|-------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------|
    -| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3 then minor compaction will be triggered for every 2 segments. 3 is the number of level 1 compacted segment which is further compacted to new segment. | NA |
    +| carbon.compaction.level.threshold | 4, 3 | Minor | This property is for minor compaction which decides how many segments to be merged. Example: If it is set as 2, 3, then minor compaction will be triggered for every 2 segments in level 1. 3 is the number of level 1 compacted segment which is further compacted to new segment in level 2. | NA |
    --- End diff --
   
    I just have changed 2, 3 to "2, 3".
   
    " Minor Compaction" part has explained  level 1 compaction and  and level 2 compaction


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1357
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/156/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1357
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/786/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1357


---