[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max DataMap

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/113/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/237/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/868/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/238/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/114/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/869/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r139889234
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -42,6 +44,15 @@
        */
       List<Blocklet> prune(FilterResolverIntf filterExp);
     
    +  /**
    +   * Prune the datamap with blockletId. It returns the list of
    +   * blocklets where these filters can exist.
    +   *
    +   * @param filterExp
    +   * @param blockletId
    +   * @return
    +   */
    +  List<Blocklet> pruneBlockletFromBlockId(FilterResolverIntf filterExp, int blockletId);
    --- End diff --
   
    what is blockletId? I don't think this method is required in datamap


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r139890369
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -42,6 +44,15 @@
        */
       List<Blocklet> prune(FilterResolverIntf filterExp);
     
    +  /**
    +   * Prune the datamap with blockletId. It returns the list of
    +   * blocklets where these filters can exist.
    +   *
    +   * @param filterExp
    +   * @param blockletId
    +   * @return
    +   */
    +  List<Blocklet> pruneBlockletFromBlockId(FilterResolverIntf filterExp, int blockletId);
    --- End diff --
   
    BlockletId is the output of Min Max DataMap and the same is passed to BlockletDataMap in order to form the complete blocklet.
    Instead of declaring the method pruneBlockletFromBlockId in DataMap, the same can be made a local function to blockletId.



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    @sounakr can you make it simpler. Please add datamap that can just return blocklet details with block+blockletid. Lets worn on integration on other PR.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    @sounakr I feel this same as Ravindra, let's make the example in a simplest way, so that developers can understand the concept of datamap and the usage of it in short time.  


---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    @ravipesala and @jackylk , sure will make it simple. Will check if some more interfaces needs to be opened.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    @sounakr Please add example based on the PR https://github.com/apache/carbondata/pull/1376 .


---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/327/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/203/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/954/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/955/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/246/



---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Retest this please.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/370/



---