[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max DataMap

classic Classic list List threaded Threaded
118 messages Options
123456
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/371/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/247/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/998/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/999/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1000/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/400/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/278/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/401/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1031/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1032/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143708356
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java ---
    @@ -0,0 +1,30 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.indexstore;
    +
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +
    +public interface SegmentPropertiesFetcher {
    +
    +  SegmentProperties getSegmentProperties(String filePath) throws IOException;
    --- End diff --
   
    I thnk it is segmentID


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143708431
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java ---
    @@ -0,0 +1,30 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.indexstore;
    +
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +
    +public interface SegmentPropertiesFetcher {
    +
    +  SegmentProperties getSegmentProperties(String filePath) throws IOException;
    +
    +  SegmentProperties getSegmentProperties(AbsoluteTableIdentifier absoluteTableIdentifier);
    --- End diff --
   
    Don't add if it is not used


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/410/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1359: [CARBONDATA-1480]Min Max Index Example for DataMap

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1359
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/287/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143709914
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java ---
    @@ -0,0 +1,30 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.indexstore;
    +
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +
    +public interface SegmentPropertiesFetcher {
    +
    +  SegmentProperties getSegmentProperties(String filePath) throws IOException;
    --- End diff --
   
    Yes, it is SegmentId. Rectified.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143709953
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java ---
    @@ -0,0 +1,30 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.indexstore;
    +
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +
    +public interface SegmentPropertiesFetcher {
    +
    +  SegmentProperties getSegmentProperties(String filePath) throws IOException;
    +
    +  SegmentProperties getSegmentProperties(AbsoluteTableIdentifier absoluteTableIdentifier);
    --- End diff --
   
    Done. Removed it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143710464
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java ---
    @@ -219,4 +225,27 @@ public DataMapMeta getMeta() {
         // TODO: pass SORT_COLUMNS into this class
         return null;
       }
    +
    +  @Override public SegmentProperties getSegmentProperties(String segmentId) throws IOException {
    +    SegmentProperties segmentProperties = null;
    --- End diff --
   
    SegmentProperties need to be cached, it shouldn't read from disk always


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143710556
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/MinMaxBlockletComparator.java ---
    @@ -0,0 +1,134 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.examples;
    +
    +import java.nio.ByteBuffer;
    +import java.util.Comparator;
    +
    +import org.apache.carbondata.core.util.ByteUtil;
    +
    +
    +/**
    + * Data map comparator
    + */
    +public class MinMaxBlockletComparator implements Comparator<byte[]> {
    --- End diff --
   
    I think this class is not required


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143710670
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/MinMaxDataMap.java ---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples;
    +
    +import java.io.BufferedReader;
    +import java.io.DataInputStream;
    +import java.io.IOException;
    +import java.io.InputStreamReader;
    +import java.util.ArrayList;
    +import java.util.BitSet;
    +import java.util.List;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +import org.apache.carbondata.core.cache.Cacheable;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datamap.dev.DataMap;
    +import org.apache.carbondata.core.datastore.IndexKey;
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
    +import org.apache.carbondata.core.datastore.filesystem.CarbonFileFilter;
    +import org.apache.carbondata.core.datastore.impl.FileFactory;
    +import org.apache.carbondata.core.fileoperations.AtomicFileOperations;
    +import org.apache.carbondata.core.fileoperations.AtomicFileOperationsImpl;
    +import org.apache.carbondata.core.indexstore.Blocklet;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.scan.filter.FilterUtil;
    +import org.apache.carbondata.core.scan.filter.executer.FilterExecuter;
    +import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +
    +import com.google.gson.Gson;
    +
    +/**
    + * Datamap implementation for min max blocklet.
    + */
    +public class MinMaxDataMap implements DataMap, Cacheable {
    +
    +  private static final LogService LOGGER =
    +      LogServiceFactory.getLogService(MinMaxDataMap.class.getName());
    +
    +  public static final String NAME = "clustered.minmax.btree.blocklet";
    +
    +  private String filePath;
    +
    +  private MinMaxIndexBlockDetails[] readMinMaxDataMap;
    +
    +  @Override public void init(String filePath) throws MemoryException, IOException {
    +    this.filePath = filePath;
    +    CarbonFile[] listFiles = getCarbonIndexFiles(filePath, "0");
    +    for (int i = 0; i < listFiles.length; i++) {
    +      readMinMaxDataMap = readJson(listFiles[i].getPath());
    +    }
    +  }
    +
    +  private CarbonFile[] getCarbonIndexFiles(String filePath, String segmentId) {
    --- End diff --
   
    change the method nme


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143711091
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/MinMaxDataMap.java ---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples;
    +
    +import java.io.BufferedReader;
    +import java.io.DataInputStream;
    +import java.io.IOException;
    +import java.io.InputStreamReader;
    +import java.util.ArrayList;
    +import java.util.BitSet;
    +import java.util.List;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +import org.apache.carbondata.core.cache.Cacheable;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datamap.dev.DataMap;
    +import org.apache.carbondata.core.datastore.IndexKey;
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
    +import org.apache.carbondata.core.datastore.filesystem.CarbonFileFilter;
    +import org.apache.carbondata.core.datastore.impl.FileFactory;
    +import org.apache.carbondata.core.fileoperations.AtomicFileOperations;
    +import org.apache.carbondata.core.fileoperations.AtomicFileOperationsImpl;
    +import org.apache.carbondata.core.indexstore.Blocklet;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.scan.filter.FilterUtil;
    +import org.apache.carbondata.core.scan.filter.executer.FilterExecuter;
    +import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +
    +import com.google.gson.Gson;
    +
    +/**
    + * Datamap implementation for min max blocklet.
    + */
    +public class MinMaxDataMap implements DataMap, Cacheable {
    --- End diff --
   
    don't implement Cacheable


---
123456