[GitHub] carbondata pull request #1412: [CARBONDATA-1510] UDF test case added

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/1412

    [CARBONDATA-1510] UDF test case added

    UDF is already working fine . So this PR contains only the test case  for UDF with complex data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-1510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1412
   
----
commit 3d184cacdd0127349c1eb3bbeef8a766b8b91877
Author: rahulforallp <[hidden email]>
Date:   2017-10-12T13:18:14Z

    [CARBONDATA-1510] UDF test case added

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/437/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/312/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1066/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/315/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/440/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1069/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1412#discussion_r145858244
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/udf/TestUdf.scala ---
    @@ -0,0 +1,103 @@
    +package org.apache.carbondata.spark.testsuite.udf
    +
    +import org.apache.spark.sql.Row
    +import org.apache.spark.sql.test.util.QueryTest
    +import org.apache.spark.sql.types.{DataType, StringType, StructField, StructType}
    +import org.scalatest.BeforeAndAfterAll
    +
    +class TestUdf extends QueryTest with BeforeAndAfterAll {
    --- End diff --
   
    Can you rename to mention it is for complex type UDF test?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1412#discussion_r145858296
 
    --- Diff: integration/spark-common-test/pom.xml ---
    @@ -116,7 +116,6 @@
       </dependencies>
     
       <build>
    -    <testSourceDirectory>src/test/scala</testSourceDirectory>
    --- End diff --
   
    Is it required to remove this?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1178/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/547/



---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1412#discussion_r146219697
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/udf/TestUdf.scala ---
    @@ -0,0 +1,103 @@
    +package org.apache.carbondata.spark.testsuite.udf
    +
    +import org.apache.spark.sql.Row
    +import org.apache.spark.sql.test.util.QueryTest
    +import org.apache.spark.sql.types.{DataType, StringType, StructField, StructType}
    +import org.scalatest.BeforeAndAfterAll
    +
    +class TestUdf extends QueryTest with BeforeAndAfterAll {
    --- End diff --
   
    @jackylk rename done


---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1412#discussion_r146219888
 
    --- Diff: integration/spark-common-test/pom.xml ---
    @@ -116,7 +116,6 @@
       </dependencies>
     
       <build>
    -    <testSourceDirectory>src/test/scala</testSourceDirectory>
    --- End diff --
   
    I have removed this because I have added java file . And that java file also need to be compiled.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1280/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/652/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/724/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1361/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/807/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1440/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/1412
 
    @jackylk review comment resolved . please review and merge.


---