[GitHub] carbondata pull request #1439: [CARBONDATA-1628] Re-factory LoadTableCommand...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1439

    [CARBONDATA-1628] Re-factory LoadTableCommand to reuse code for streaming ingest in the future

    Re-factory LoadTableCommand to reuse code for streaming ingest in the future

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata refactory_loadtable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1439
   
----
commit 53e4ad765cc530446980626a638dd6f90da5a692
Author: QiangCai <[hidden email]>
Date:   2017-10-27T08:06:06Z

    refactory_loadtable

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/693/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/695/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/696/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1328/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1330/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1331/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    @mohammadshahidkhan @kumarvishal09 please help to review this PR


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1439#discussion_r147454328
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -831,4 +835,207 @@ object CommonUtil {
             LOGGER.error(s)
         }
       }
    +
    +  def getFinalOptions(carbonProperty: CarbonProperties,
    --- End diff --
   
    Please change the method name


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/708/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1343/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1344/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    +1 LGTM


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    LGTM


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1439#discussion_r147551479
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala ---
    @@ -0,0 +1,300 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.util
    +
    +import scala.collection.immutable
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.common.constants.LoggerAction
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.{CarbonCommonConstants, CarbonLoadOptionConstants}
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable
    +import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
    +import org.apache.carbondata.processing.loading.constants.DataLoadProcessorConstants
    +import org.apache.carbondata.processing.loading.model.{CarbonDataLoadSchema, CarbonLoadModel}
    +import org.apache.carbondata.processing.util.TableOptionConstant
    +import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
    +import org.apache.carbondata.spark.load.ValidateUtil
    +
    +/**
    + * the util object of data loading
    + */
    +object DataLoadingUtil {
    --- End diff --
   
    Can you move this class and org.apache.carbondata.spark.exception.MalformedCarbonCommandException,  org.apache.carbondata.spark.load.ValidateUtil to carbon-processing module?
    You can still keep it as scala code. Since it is not depend on spark, I think it is better to move to processing module


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    Can you tag the PR title with [Streaming] as discussed in maillist


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1439#discussion_r147604429
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala ---
    @@ -0,0 +1,300 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.util
    +
    +import scala.collection.immutable
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.common.constants.LoggerAction
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.{CarbonCommonConstants, CarbonLoadOptionConstants}
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable
    +import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
    +import org.apache.carbondata.processing.loading.constants.DataLoadProcessorConstants
    +import org.apache.carbondata.processing.loading.model.{CarbonDataLoadSchema, CarbonLoadModel}
    +import org.apache.carbondata.processing.util.TableOptionConstant
    +import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
    +import org.apache.carbondata.spark.load.ValidateUtil
    +
    +/**
    + * the util object of data loading
    + */
    +object DataLoadingUtil {
    --- End diff --
   
    I think these classes are still the part of Integration. They bridge the difference between spark module and the processing module.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1439#discussion_r147649830
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala ---
    @@ -0,0 +1,300 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.util
    +
    +import scala.collection.immutable
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.common.constants.LoggerAction
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.{CarbonCommonConstants, CarbonLoadOptionConstants}
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable
    +import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
    +import org.apache.carbondata.processing.loading.constants.DataLoadProcessorConstants
    +import org.apache.carbondata.processing.loading.model.{CarbonDataLoadSchema, CarbonLoadModel}
    +import org.apache.carbondata.processing.util.TableOptionConstant
    +import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
    +import org.apache.carbondata.spark.load.ValidateUtil
    +
    +/**
    + * the util object of data loading
    + */
    +object DataLoadingUtil {
    --- End diff --
   
    I can accept it now, as long as there is no other compute engine uses it.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1439
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1439


---