[GitHub] carbondata pull request #1459: [CARBONDATA-1661] Fixed bug related to displa...

[qiuchenjian-2]

GitHub user geetikagupta16 opened a pull request:

    https://github.com/apache/carbondata/pull/1459

    [CARBONDATA-1661] Fixed bug related to display of timestamp values in presto

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-1661

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1459
   
----
commit fccfdc6be7be70467c31297ef318581d575c0a87
Author: Geetika Gupta <[hidden email]>
Date:   2017-11-01T11:12:20Z

    Fixed bug related to display of timestamp values in presto

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1459
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/788/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1459
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1421/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1459#discussion_r148986553
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
    @@ -258,6 +258,8 @@ else if (type instanceof DecimalType) {
             return new BigDecimal(new BigInteger(String.valueOf(rawdata)),
                 ((DecimalType) type).getScale());
           }
    +    } else if (type.equals(TimestampType.TIMESTAMP)) {
    --- End diff --
   
    You can use `type == DataTypes.TIMESTAMP` instead


---

[qiuchenjian-2]

Github user geetikagupta16 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1459#discussion_r148998311
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
    @@ -258,6 +258,8 @@ else if (type instanceof DecimalType) {
             return new BigDecimal(new BigInteger(String.valueOf(rawdata)),
                 ((DecimalType) type).getScale());
           }
    +    } else if (type.equals(TimestampType.TIMESTAMP)) {
    --- End diff --
   
    Here I am comparing the type with Presto's datatypes that's why I have used `TimestampType.TIMESTAMP`


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1459
 
    verified. LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1459


---