[GitHub] carbondata pull request #1480: [CARBONDATA-1693] Change SegmentStatus from S...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1480

    [CARBONDATA-1693] Change SegmentStatus from String to enum

    Currently Segment status definition is scatter in multiple class, this PR unified them into a Enum class.
   
     - [X] Any interfaces changed?
     SegmentStatus enum is added
   
     - [X] Any backward compatibility impacted?
     No
   
     - [X] Document update required?
    No
   
     - [X] Testing done
    No new testcase added
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata segment_enum

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1480
   
----
commit 81e5e6d5bbb625b4f9528ff56a7206b215f71566
Author: Jacky Li <[hidden email]>
Date:   2017-11-09T17:34:58Z

    add SegmentStatus enum

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/940/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1555/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/944/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1559/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/959/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/963/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150210639
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/SparkDataMapJob.scala ---
    @@ -31,6 +31,7 @@ import org.apache.carbondata.common.logging.LogServiceFactory
     import org.apache.carbondata.core.constants.CarbonCommonConstants
     import org.apache.carbondata.core.indexstore.ExtendedBlocklet
     import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf
    +import org.apache.carbondata.core.statusmanager.SegmentStatus
    --- End diff --
   
    I think this import is not needed


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150210859
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/ShowSegments.scala ---
    @@ -1,88 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements.  See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License.  You may obtain a copy of the License at
    - *
    - *    http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -
    -package org.apache.spark.util
    -
    -import java.text.SimpleDateFormat
    -
    -import org.apache.commons.lang3.StringUtils
    -import org.apache.spark.sql.{CarbonEnv, Row, SparkSession}
    -import org.apache.spark.sql.hive.CarbonRelation
    -
    -import org.apache.carbondata.api.CarbonStore
    -
    -// scalastyle:off
    -object ShowSegments {
    --- End diff --
   
    I think related testcases also need to be removed


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1574/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150240886
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/SparkDataMapJob.scala ---
    @@ -31,6 +31,7 @@ import org.apache.carbondata.common.logging.LogServiceFactory
     import org.apache.carbondata.core.constants.CarbonCommonConstants
     import org.apache.carbondata.core.indexstore.ExtendedBlocklet
     import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf
    +import org.apache.carbondata.core.statusmanager.SegmentStatus
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1578/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/972/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/978/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1586/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1589/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1027/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1028/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1645/



---