[GitHub] carbondata pull request #1480: [CARBONDATA-1693] Change SegmentStatus from S...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1646/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1036/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1654/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1038/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1656/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150436256
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -522,33 +522,8 @@
        * LEVEL_METADATA_FILE
        */
       public static final String LEVEL_METADATA_FILE = "levelmetadata_";
    -  /**
    -   * LOAD_STATUS SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_SUCCESS = "Success";
    -  /**
    -   * LOAD_STATUS UPDATE
    -   */
    -  public static final String STORE_LOADSTATUS_UPDATE = "Update";
    -  /**
    -   * LOAD_STATUS FAILURE
    -   */
    -  public static final String STORE_LOADSTATUS_FAILURE = "Failure";
    -  /**
    -   * LOAD_STATUS PARTIAL_SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_PARTIAL_SUCCESS = "Partial Success";
    -
    -  /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING = "Streaming";
     
       /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING_FINISH = "Streaming Finish";
    -  /**
        * LOAD_STATUS
        */
       public static final String CARBON_METADATA_EXTENSION = ".metadata";
    --- End diff --
   
    The next comment also need be corrected.


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150437817
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/MajorCompactionIgnoreInMinorTest.scala ---
    @@ -118,7 +119,7 @@ class MajorCompactionIgnoreInMinorTest extends QueryTest with BeforeAndAfterAll
         val segs = SegmentStatusManager.readLoadMetadata(carbontablePath)
     
         // status should remain as compacted.
    -    assert(segs(3).getLoadStatus.equalsIgnoreCase(CarbonCommonConstants.COMPACTED))
    +    assert(segs(3).getSegmentStatus == SegmentStatus.COMPACTED)
    --- End diff --
   
    use assertEquals


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150436176
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -522,33 +522,8 @@
        * LEVEL_METADATA_FILE
        */
       public static final String LEVEL_METADATA_FILE = "levelmetadata_";
    -  /**
    -   * LOAD_STATUS SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_SUCCESS = "Success";
    -  /**
    -   * LOAD_STATUS UPDATE
    -   */
    -  public static final String STORE_LOADSTATUS_UPDATE = "Update";
    -  /**
    -   * LOAD_STATUS FAILURE
    -   */
    -  public static final String STORE_LOADSTATUS_FAILURE = "Failure";
    -  /**
    -   * LOAD_STATUS PARTIAL_SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_PARTIAL_SUCCESS = "Partial Success";
    -
    -  /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING = "Streaming";
     
       /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING_FINISH = "Streaming Finish";
    -  /**
        * LOAD_STATUS
        */
       public static final String CARBON_METADATA_EXTENSION = ".metadata";
    --- End diff --
   
    The comment is not proper.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1480#discussion_r150443631
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -522,33 +522,8 @@
        * LEVEL_METADATA_FILE
        */
       public static final String LEVEL_METADATA_FILE = "levelmetadata_";
    -  /**
    -   * LOAD_STATUS SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_SUCCESS = "Success";
    -  /**
    -   * LOAD_STATUS UPDATE
    -   */
    -  public static final String STORE_LOADSTATUS_UPDATE = "Update";
    -  /**
    -   * LOAD_STATUS FAILURE
    -   */
    -  public static final String STORE_LOADSTATUS_FAILURE = "Failure";
    -  /**
    -   * LOAD_STATUS PARTIAL_SUCCESS
    -   */
    -  public static final String STORE_LOADSTATUS_PARTIAL_SUCCESS = "Partial Success";
    -
    -  /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING = "Streaming";
     
       /**
    -   * STORE_LOADSTATUS_STREAMING
    -   */
    -  public static final String STORE_LOADSTATUS_STREAMING_FINISH = "Streaming Finish";
    -  /**
        * LOAD_STATUS
        */
       public static final String CARBON_METADATA_EXTENSION = ".metadata";
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1040/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1658/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1045/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1663/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1050/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1668/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1065/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1069/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1676/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1679/



---