[GitHub] carbondata pull request #1491: [CARBONDATA-1651] [Supported Boolean Type Whe...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/carbondata/pull/1491

    [CARBONDATA-1651] [Supported Boolean Type When Saving DataFrame] Provided Support For Boolean Data Type In CarbonDataFrameWriter

    1.Provided Support For Boolean Data Type In CarbonDataFrameWriter
    2.Test Cases are Added For Same
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1651

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1491
   
----
commit c9433e46c6a7bd5ae40a747214346f931fa2581a
Author: anubhav100 <[hidden email]>
Date:   2017-11-13T08:03:15Z

    Provided Support For Boolean Data Type In CarbonDataFrameWriter

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1047/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1665/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1491#discussion_r150842701
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataFrame.scala ---
    @@ -70,7 +82,17 @@ class TestLoadDataFrame extends QueryTest with BeforeAndAfterAll {
         buildTestData
       }
     
    -
    +test("test the boolean data type"){
    +  booldf.write
    +    .format("carbondata")
    +    .option("tableName", "carbon10")
    +    .option("tempCSV", "true")
    +    .option("compress", "true")
    +    .mode(SaveMode.Overwrite)
    +    .save()
    +  checkAnswer(
    +  sql("SELECT * FROM CARBON10"),Seq(Row("anubhav",true),Row("prince",false)))
    --- End diff --
   
    change to
    ```
    checkAnswer(
         sql("SELECT * FROM CARBON10"),
         Seq(Row("anubhav", true), Row("prince", false)))
    ```


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1491#discussion_r150858848
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataFrame.scala ---
    @@ -70,7 +82,17 @@ class TestLoadDataFrame extends QueryTest with BeforeAndAfterAll {
         buildTestData
       }
     
    -
    +test("test the boolean data type"){
    +  booldf.write
    +    .format("carbondata")
    +    .option("tableName", "carbon10")
    +    .option("tempCSV", "true")
    +    .option("compress", "true")
    +    .mode(SaveMode.Overwrite)
    +    .save()
    +  checkAnswer(
    +  sql("SELECT * FROM CARBON10"),Seq(Row("anubhav",true),Row("prince",false)))
    --- End diff --
   
    @jackylk i have done the changes you can review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1124/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Retest this


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1720/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1138/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    @jackylk why build is failing i have clean build on machine and also resolved all review comments


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1212/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1226/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1491
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1491


---