[GitHub] carbondata pull request #1500: [WIP]Remove spark broadcast for gettting hado...

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1500

    [WIP]Remove spark broadcast for gettting hadoop configurations

    why?
    with the new conf set in hadoop conf, after broadcast conf will not get reflected, hence these changes
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [*] Any interfaces changed?
     NONE
     - [*] Any backward compatibility impacted?
     NONE
     - [ ] Document update required?
    NONE
     - [*] Testing done
           test cases are not required, SDV will take care
           
     - [*] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NONE
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata conf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1500
   
----
commit e86bf0809dd1270126b99f5c61f92c84ba5a2ed8
Author: akashrn5 <[hidden email]>
Date:   2017-10-27T12:41:03Z

    remove spark broadcast for gettting hadoop configurations

----


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    @QiangCai please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1147/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    @ravipesala @jackylk please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1149/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1150/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    please fix CI issue


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    retest sdv pleaase


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1173/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1500
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1500


---