[GitHub] carbondata pull request #1509: [CARBONDATA-1739] Clean up store path interfa...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1509

    [CARBONDATA-1739] Clean up store path interface

    There are many getStorePath API, this PR unified it in one place: `CarbonProperties.getStorePath`
    It can be used in driver side
   
     - [X] Any interfaces changed?
     Yes
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    No new testcase is added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    MR2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata tableinfo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1509
   
----
commit 09ff30688fe84c199fb86b92b9547c859e05a75c
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T09:27:21Z

    add s3 in filefactory

commit 8d31b0974071bb7cd8ad72aa58990b9f2621b8a1
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T11:41:19Z

    remove unnecessary path

commit 5a7008e0691daff9bad3c8bf707d0592500a1f24
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T12:56:55Z

    clean CarbonEnv

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1183/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1198/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1199/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    I found the commit 'add s3 in filefactory' appears in many prs.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1201/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    @zzcclp because I implement those PR one by one, so it is on top of #1504


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1208/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1509
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1509


---