[GitHub] carbondata pull request #1535: [CARBONDATA-1771] While segment_index compact...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1535

    [CARBONDATA-1771] While segment_index compaction, .carbonindex files of invalid segments are also getting merged

    **Scenario:**
    Disable feature, do loads, execute MINOR compaction
    Execute SEGMENT_INDEX compaction
    SEGMENT_INDEX  compaction merges .carbonindex files of compacted invalid segments also
   
    **Solution:**
    Merge index files of valid segments only
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [X] Testing done
            UT Added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata index_compaction

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1535
   
----
commit 9462791bb5ef5eb9dbc9f7c3a8c97ef3e6ad7dfb
Author: dhatchayani <[hidden email]>
Date:   2017-11-19T15:23:50Z

    [CARBONDATA-1771] While segment_index compaction, .carbonindex files of invalid segments are also getting merged

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1290/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1291/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1760/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1774/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1535
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1535


---