[GitHub] carbondata pull request #1544: [CARBONDATA-1740] Fixed order by issue in cas...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1691/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/423/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2082/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1694/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1544#discussion_r154738692
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
    @@ -215,6 +296,49 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
         }
       }
     
    +  /**
    +   * Below method will be used to extract columns from order by expression
    +   * @param projectList
    +   *                    project list from plan
    +   * @param sortOrders
    +   *                   sort order in plan
    +   * @param carbonTable
    +   *                    carbon table
    +   * @param tableName
    +   *                  table name
    +   * @return query columns from expression
    +   */
    +  def extractQueryColumnForOrderBy(projectList: Option[Seq[NamedExpression]] = None,
    +      sortOrders: Seq[SortOrder],
    +      carbonTable: CarbonTable,
    +      tableName: String): Seq[QueryColumn] = {
    +    val list = scala.collection.mutable.ListBuffer.empty[QueryColumn]
    +    if(projectList.isDefined) {
    +      projectList.get.map {
    +        proList =>
    +          proList.transform {
    +            case attr: AttributeReference =>
    +              val queryColumn = getQueryColumn(attr.name, carbonTable, tableName)
    +              if (null != queryColumn) {
    +                list += queryColumn
    --- End diff --
   
    Ok


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1544


---