[GitHub] carbondata pull request #1544: [CARBONDATA-1740] Fixed order by issue in cas...

[qiuchenjian-2]

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1544

    [CARBONDATA-1740] Fixed order by issue in case of preAggregate

    Fixed order by issue in case of preAggregate
   
     - [ ] Any interfaces changed- None
     
     - [ ] Any backward compatibility impacted- None
     
     - [ ] Document update required- None
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata master-1740

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1544
   
----
commit 4d5a9cb6222799103b8b377862bcfd0ff5ffb0dc
Author: kumarvishal <[hidden email]>
Date:   2017-11-20T11:06:11Z

    Fixed 1740

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1335/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1792/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1795/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1341/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1398/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1843/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    @kumarvishal09 Add PR description


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1544#discussion_r153068779
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
    @@ -160,6 +155,90 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
                 tableName,
                 list)
               carbonTable
    +        // case for handling aggregation, order by
    +        case Project(projectList, Sort(sortOrders, _, Aggregate(groupingExp,
    --- End diff --
   
    Can you avoid duplicate code by applying recursive call


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1483/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1902/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1564/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1963/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1573/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1970/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1604/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1998/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/410/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2068/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1544
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/412/



---