[GitHub] carbondata pull request #1554: [CARBONDATA-1717] Fix issue of no sort when d...

[qiuchenjian-2]

GitHub user chenerlu opened a pull request:

    https://github.com/apache/carbondata/pull/1554

    [CARBONDATA-1717] Fix issue of no sort when data in carbon table is all numeric

    Modification reason: Fix issue of no sort when data in carbon table is all numeric.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenerlu/incubator-carbondata 1122

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1554
   
----
commit ac84728dbc7ca064149c5b61a10ae4686c729d2d
Author: chenerlu <[hidden email]>
Date:   2017-11-22T15:04:13Z

    [CARBONDATA-1717] Fix issue of no sort when data in carbon table is all numeric

----


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    @chenerlu  please follow the below template to provide description.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1374/



---

[qiuchenjian-2]

Github user chenerlu commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1827/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1378/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    @chenerlu
    can you unify the variable name to "hadoopConf"?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1384/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    LGTM


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1832/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1554
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1554


---