[GitHub] carbondata pull request #1561: [CARBONDATA-1802] Alter query fails if a colu...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1561: [CARBONDATA-1802] Alter query fails if a colu...

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1561

    [CARBONDATA-1802] Alter query fails if a column is dropped and there is no key column

    (1) Alter query fails if a column is dropped and there is no key column
    All key columns in a carbon table can be dropped, as we are supporting table creation with no keycolumn, alter also should be consistent with this.
   
    (2) Table already exists exception is wrong. Corrected error message
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [X] Testing done
            UT Added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata alter_command

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1561
   
----
commit 88fa0f1b5416c55cadafeaf0e5ae10a416a0cf6e
Author: dhatchayani <[hidden email]>
Date:   2017-11-24T08:53:04Z

    Alter query fails if a column is dropped and there is no key column

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1561: [CARBONDATA-1802] Alter query fails if a column is d...

qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1561
 
    LGMT


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1561: [CARBONDATA-1802] Alter query fails if a column is d...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1561
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1592/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1561: [CARBONDATA-1802] Alter query fails if a column is d...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1561
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1988/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1561: [CARBONDATA-1802] Alter query fails if a column is d...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1561
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1609/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1561: [CARBONDATA-1802] Alter query fails if a column is d...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1561
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2003/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1561: [CARBONDATA-1802] Alter query fails if a colu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1561


---