[GitHub] carbondata pull request #1562: [CARBONDATA-1592] Added event listeners

[qiuchenjian-2]

GitHub user ManoharVanam opened a pull request:

    https://github.com/apache/carbondata/pull/1562

    [CARBONDATA-1592] Added event listeners

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata Listeners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1562
   
----
commit 6892b337dab293dd1e986dfa4178105b1bda27da
Author: Manohar <[hidden email]>
Date:   2017-11-24T09:41:59Z

    [CARBONDATA-1592] Added event listeners

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1857/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1432/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    @ManoharVanam please rebase


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1496/



---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1562#discussion_r153192273
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala ---
    @@ -139,6 +140,15 @@ case class LoadTableCommand(
             carbonLoadModel,
             hadoopConf
           )
    +      val operationContext = new OperationContext
    +      val loadTablePreExecutionEvent: LoadTablePreExecutionEvent =
    +        new LoadTablePreExecutionEvent(sparkSession,
    +          null,
    +          carbonLoadModel,
    +          factPath,
    +          dataFrame.isDefined,
    +          optionsFinal)
    --- End diff --
   
    carbonloadmodel is already getting passed... it there any other property that is getting used from optionsFinal variable?


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    Apart from 1 comment given, LGTM


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1562#discussion_r153193864
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala ---
    @@ -139,6 +140,15 @@ case class LoadTableCommand(
             carbonLoadModel,
             hadoopConf
           )
    +      val operationContext = new OperationContext
    +      val loadTablePreExecutionEvent: LoadTablePreExecutionEvent =
    +        new LoadTablePreExecutionEvent(sparkSession,
    +          null,
    +          carbonLoadModel,
    +          factPath,
    +          dataFrame.isDefined,
    +          optionsFinal)
    --- End diff --
   
    yeah , Iam getting bad records info from optionsFinal for validation purpose in pre event listener.
    after validating we are setting to carbonLoadModel, so this is required


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1562#discussion_r153195294
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala ---
    @@ -139,6 +140,15 @@ case class LoadTableCommand(
             carbonLoadModel,
             hadoopConf
           )
    +      val operationContext = new OperationContext
    +      val loadTablePreExecutionEvent: LoadTablePreExecutionEvent =
    +        new LoadTablePreExecutionEvent(sparkSession,
    +          null,
    +          carbonLoadModel,
    +          factPath,
    +          dataFrame.isDefined,
    +          optionsFinal)
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1505/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1913/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1538/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1939/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1562
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1562


---