[GitHub] carbondata pull request #1569: [CARBONDATA-1752] There are some scalastyle e...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1569: [CARBONDATA-1752] There are some scalastyle e...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1569

    [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData

   
    There are some scalastyle error should be optimized in CarbonData, including removing useless import, optimizing method definition and so on
   
    This PR remove some unused import like:
   
    ```
    import org.apache.carbondata.core.metadata.datatype.DecimalType
    import org.apache.carbondata.core.metadata.datatype.DataType;
   
    ```
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     NO
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata fixStyle3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1569
   
----
commit 9f4dc338acc4745ab72d3cae8694b9d768306e5b
Author: xubo245 <[hidden email]>
Date:   2017-11-26T12:10:30Z

    [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData
   
    There are some scalastyle error should be optimized in CarbonData, including removing useless import, optimizing method definition and so on
   
    This PR remove some unused import like:
    import org.apache.carbondata.core.metadata.datatype.DecimalType
    import org.apache.carbondata.core.metadata.datatype.DataType;

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1468/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1886/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2047/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1657/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/411/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1683/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2069/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1569: [CARBONDATA-1752] There are some scalastyle e...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1569


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1569
 
    LGTM


---