[GitHub] carbondata pull request #1588: [CARBONDATA-1834] when running insert overwri...

[qiuchenjian-2]

GitHub user kushalsaha opened a pull request:

    https://github.com/apache/carbondata/pull/1588

    [CARBONDATA-1834] when running insert overwrite task and parallely executing select query task throwing FileNotFoundException so we modify the log message

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kushalsaha/carbondata 29Nov_logMessage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1588
   
----
commit e5b82bfd680daca34616fc59379273ff4b7beac6
Author: Pawan Malwal <[hidden email]>
Date:   2017-11-29T07:35:57Z

    [CARBONDATA-1834] when running insert overwrite task

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1561/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1960/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1596/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1992/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1588#discussion_r154007357
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -116,6 +117,14 @@ public VectorizedCarbonRecordReader(QueryModel queryModel, InputMetricsStats inp
           queryExecutor = QueryExecutorFactory.getQueryExecutor(queryModel);
           iterator = (AbstractDetailQueryResultIterator) queryExecutor.execute(queryModel);
         } catch (QueryExecutionException e) {
    +      Throwable ext = e;
    +      while (ext != null) {
    +        if (ext instanceof FileNotFoundException) {
    +          throw new InterruptedException(
    --- End diff --
   
    better pass the exception along with message to the constructor


---

[qiuchenjian-2]

Github user kushalsaha commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1588#discussion_r154085432
 
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -116,6 +117,14 @@ public VectorizedCarbonRecordReader(QueryModel queryModel, InputMetricsStats inp
           queryExecutor = QueryExecutorFactory.getQueryExecutor(queryModel);
           iterator = (AbstractDetailQueryResultIterator) queryExecutor.execute(queryModel);
         } catch (QueryExecutionException e) {
    +      Throwable ext = e;
    +      while (ext != null) {
    +        if (ext instanceof FileNotFoundException) {
    +          throw new InterruptedException(
    --- End diff --
   
    InterruptedException takes only one parameter that's only message


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1588
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1588


---