[GitHub] carbondata pull request #1590: [CARBONDATA-1814] Fixed bug for alter operati...

[qiuchenjian-2]

GitHub user geetikagupta16 opened a pull request:

    https://github.com/apache/carbondata/pull/1590

    [CARBONDATA-1814] Fixed bug for alter operation on tblProperties in streaming table

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-1814

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1590
   
----
commit cf7f487462925228bb5710d8a90ac89de716d98d
Author: Geetika Gupta <[hidden email]>
Date:   2017-11-29T11:03:59Z

    Fixed bug for alter operation in streaming table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1571/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    please move test case to here from PR-1591


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    @QiangCai yes we will do it now


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1969/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1593/



---

[qiuchenjian-2]

Github user geetikagupta16 commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1989/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1594/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1590


---

[qiuchenjian-2]

Github user geetikagupta16 commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    @QiangCai I can't see my commit in the master branch. Can you please check.


---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1590
 
    @geetikagupta16
    oh, sorry, my mistake, the author is incorrect.
    during mergeing, I squash the second commit to the first commit.
    But I don't known the author of first commit is me.


---