[GitHub] carbondata pull request #1610: [CARBONDATA-1879]do not drop the table if the...

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1610

    [CARBONDATA-1879]do not drop the table if the load, insert or insert overwrite is in progress

    do not drop the table if the load, insert or insert overwrite is in progress
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [*] Any interfaces changed?
     NA
     - [*] Any backward compatibility impacted?
     NA
     - [*] Document update required?
    NA
     - [*] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           local testing is done
     - [*] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata drop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1610
   
----
commit a0e516709f6b2053845fc882c02a0ee7aee91fac
Author: akashrn5 <[hidden email]>
Date:   2017-12-04T15:06:15Z

    do not drop the table if the load, insert or insert overwrite is in progress

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/416/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2074/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1688/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/424/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2083/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/425/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1696/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154836171
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -877,4 +877,24 @@ object CommonUtil {
         }
       }
     
    +  /**
    +   * This function checks if any load or insert overwrite is in progress before dropping that table
    +   * @return
    +   */
    +  def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
    --- End diff --
   
    Please move this method to SegmentStatusManager


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154836331
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -877,4 +877,24 @@ object CommonUtil {
         }
       }
     
    +  /**
    +   * This function checks if any load or insert overwrite is in progress before dropping that table
    +   * @return
    +   */
    +  def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
    --- End diff --
   
    Please change name of method to `checkIfAnyLoadInProgressForTable`


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154836484
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -877,4 +877,24 @@ object CommonUtil {
         }
       }
     
    +  /**
    +   * This function checks if any load or insert overwrite is in progress before dropping that table
    +   * @return
    +   */
    +  def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
    +    var canDropTable = true
    --- End diff --
   
    Rename the variable name to `loadInProgress` and initialize to `false`


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    @akashrn5 Please try to add testcase.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2087/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/433/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1703/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/434/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2088/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1704/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/438/



---