[GitHub] carbondata pull request #1620: [CARBONDATA-1864] Using org.apache.spark.SPAR...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1620

    [CARBONDATA-1864] Using org.apache.spark.SPARK_VERSION instead of sparkSession.version

    Using org.apache.spark.SPARK_VERSION instead of sparkSession.version
   
     - [x] Any interfaces changed?
     no
     - [x] Any backward compatibility impacted?
     no
     - [x] Document update required?
     no
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
              replace sparkSession.version with equivalent  org.apache.spark.SPARK_VERSION
            - How it is tested? Please attach test report.
              test case
            - Is it a performance related change? Please attach the performance test report.
               NA
            - Any additional information to help reviewers in testing this change.
               NA
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
      NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata spark_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1620
   
----
commit a6d367c689b2ee7b74e27c59e5b7672639fd840d
Author: QiangCai <[hidden email]>
Date:   2017-12-06T02:23:15Z

    Using org.apache.spark.SPARK_VERSION instead of sparkSession.version

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/482/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1746/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2130/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1620#discussion_r155254781
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala ---
    @@ -247,7 +248,7 @@ class CarbonSpark2SqlParser extends CarbonDDLSqlParser {
             val unresolvedrelation =
             CarbonReflectionUtils.getUnresolvedRelation(
               tableIdentifier,
    -          SparkSession.getActiveSession.get.version,
    +          SPARK_VERSION,
    --- End diff --
   
    can you remove this parameter and do if check inside `CarbonReflectionUtils.getUnresolvedRelation`


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/538/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1794/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/541/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2169/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2172/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1798/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1620


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/545/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1620
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1802/



---