[GitHub] carbondata pull request #1682: [CARBONDATA-1910]do not allow tupleid, refere...

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1682

    [CARBONDATA-1910]do not allow tupleid, referenceid and positionReference as columns names

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
    UTs are added to test the scenarios
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata tuple

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1682
   
----
commit 59ec63f614ce69ad2b6d8fe1fae6db2b6af93424
Author: akashrn5 <[hidden email]>
Date:   2017-12-19T13:04:10Z

    do not allow tupleid, referenceid and positionReference as columns names

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2133/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2422/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    retest this please


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/929/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2158/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2443/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    LGTM


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1682#discussion_r158012381
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
    @@ -173,6 +174,18 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
     
         // Ensuring whether no duplicate name is used in table definition
         val colNames = cols.map(_.name)
    +
    +    // do not allow below key words as column name
    +    colNames.foreach { col =>
    --- End diff --
   
    Please check scenario for CTAS... create table t1 as select sum(column1) as positionReference from table. In this case name of the column in t1 will be positionReference. So in that case also it should not allow to create carbon table.


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1682#discussion_r158012431
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala ---
    @@ -569,6 +569,39 @@ class UpdateCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
             CarbonCommonConstants.defaultValueIsPersistEnabled)
       }
     
    +  test("test create table with tupleid as column name") {
    --- End diff --
   
    Please add testcase of CTAS


---

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1682#discussion_r158022056
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala ---
    @@ -569,6 +569,39 @@ class UpdateCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
             CarbonCommonConstants.defaultValueIsPersistEnabled)
       }
     
    +  test("test create table with tupleid as column name") {
    --- End diff --
   
    added


---

[qiuchenjian-2]

Github user akashrn5 closed the pull request at:

    https://github.com/apache/carbondata/pull/1682


---

[qiuchenjian-2]

GitHub user akashrn5 reopened a pull request:

    https://github.com/apache/carbondata/pull/1682

    [CARBONDATA-1910]do not allow tupleid, referenceid and positionReference as columns names

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
    UTs are added to test the scenarios
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata tuple

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1682
   
----
commit 1dc5dd8b4490848cdab187790c0db28e40dbd354
Author: akashrn5 <akashnilugal@...>
Date:   2017-12-19T13:04:10Z

    do not allow tupleid, referenceid and positionReference as columns names

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2318/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1102/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2550/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1106/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1682
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2323/



---