[GitHub] carbondata pull request #1684: [CARBONDATA-1912] Handling lock issues

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
GitHub user ManoharVanam opened a pull request:

    https://github.com/apache/carbondata/pull/1684

    [CARBONDATA-1912] Handling lock issues

    Description :
    Getting error trace in spark-sql console while executing compaction and alter table rename commands.
   
    Scenario:
    execute compaction and alter table rename queries in spark - sql
    Even though operation is success , getting error trace on the console
   
    Solution: In compaction we are already handling unlock after operation , so we can handle unlock in catch block instead of finally block.
    In alter table rename operation: no need to unlock file on old location which will result error due to table name change.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata defect1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1684
   
----
commit c5c8fb08ca50845836e549ab5e42c506e0ace247
Author: Manohar <[hidden email]>
Date:   2017-12-19T13:42:14Z

    We are unlocking lock file after compaction, so added unlock operation at required places.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2138/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2428/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/927/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2156/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2449/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ManoharVanam commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ManoharVanam closed the pull request at:

    https://github.com/apache/carbondata/pull/1684


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
GitHub user ManoharVanam reopened a pull request:

    https://github.com/apache/carbondata/pull/1684

    [CARBONDATA-1912] Handling lock issues

    Description :
    Getting error trace in spark-sql console while executing compaction and alter table rename commands.
   
    Scenario:
    execute compaction and alter table rename queries in spark - sql
    Even though operation is success , getting error trace on the console
   
    Solution: In compaction we are already handling unlock after operation , so we can handle unlock in catch block instead of finally block.
    In alter table rename operation: no need to unlock file on old location which will result error due to table name change.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata defect1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1684
   
----
commit a0f7a661e613083e763f6589fd5ce45d025ab8cb
Author: Manohar <manohar.crazy09@...>
Date:   2017-12-19T13:42:14Z

    We are unlocking lock file after compaction, so added unlock operation at required places.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2236/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1012/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2494/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1684
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1684: [CARBONDATA-1912] Handling lock issues

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1684


---