[GitHub] carbondata pull request #1685: [CARBONDATA-1913][global_sort] Global Sort da...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1685: [CARBONDATA-1913][global_sort] Global Sort da...

qiuchenjian-2
GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/1685

    [CARBONDATA-1913][global_sort] Global Sort data dataload fails for big data with RPC timeout exception

    **Problem**
    When gloabl sort option is used for big data then for some times it fails with
    RPC timeout after 120s.
    This is happening because the driver is not able to unpersist rdd cache with in 120s.
    The issue is happening due to rdd unpersist blocking call. Sometimes spark is not able
    to unppersist the rdd in default "spark.rpc.askTimeout" or "spark.network.timeout" time.
    **Solution**
     Clean cache only if persisted and keeping unpersist non-blocking. Non blocking will not wait for cache
    clean up task to finish and non-blocking call will not have any functional impact as spark automatically monitors the cache usage on each node and drops out old data partitions in a least-recently used (LRU) fashion.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Not possible to add testcase, fails only with bigdata and failure is random.
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata global_sort_cache_invalidation_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1685
   
----
commit 1c1387ed1276d29d9389f544bb83fd62dbf46f2c
Author: mohammadshahidkhan <[hidden email]>
Date:   2017-12-19T13:48:06Z

    [CARBONDATA-1913][global_sort] Global Sort data dataload fails for big with RPC timeout exception

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2137/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2430/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2439/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/926/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2155/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    SDV failure unrelated failing randomly for other pr also


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1685: [CARBONDATA-1913][global_sort] Global Sort data data...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1685
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1685: [CARBONDATA-1913][global_sort] Global Sort da...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1685


---