[GitHub] carbondata pull request #1689: [CARBONDATA-1674] Describe formatted shows pa...

[qiuchenjian-2]

GitHub user jatin9896 opened a pull request:

    https://github.com/apache/carbondata/pull/1689

    [CARBONDATA-1674] Describe formatted shows partition type

    On desc formatted command list partition should show.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done Yes
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required? Yes
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-1674

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1689
   
----
commit a972b8e1f6747173411e2a51601496ca95027325
Author: Jatin <jatin.demla@...>
Date:   2017-12-15T04:32:12Z

    decribe formatted show partition type

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2450/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1689#discussion_r158191134
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala ---
    @@ -150,6 +150,11 @@ class TestShowPartition  extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("show partition table: desc formatted should show partition type"){
    +    //check for partition type exist in desc formatted
    +    checkExistence(sql("describe formatted hashTable"),true,"Partition Type")
    --- End diff --
   
    check the output of the type, whether it is correct


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1689#discussion_r158191173
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
    @@ -122,6 +122,9 @@ private[sql] case class CarbonDescribeFormattedCommand(
           results ++=
           Seq(("Partition Columns", carbonTable.getPartitionInfo(carbonTable.getTableName)
             .getColumnSchemaList.asScala.map(_.getColumnName).mkString(","), ""))
    +      results ++=
    +      Seq(("Partition Type: ", carbonTable.getPartitionInfo(carbonTable.getTableName)
    --- End diff --
   
    remove `:`


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2237/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1013/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2495/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2496/



---

[qiuchenjian-2]

Github user jatin9896 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1689#discussion_r158431404
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala ---
    @@ -150,6 +150,11 @@ class TestShowPartition  extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("show partition table: desc formatted should show partition type"){
    +    //check for partition type exist in desc formatted
    +    checkExistence(sql("describe formatted hashTable"),true,"Partition Type")
    --- End diff --
   
    @jackylk please review


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1689#discussion_r158573797
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala ---
    @@ -150,6 +150,14 @@ class TestShowPartition  extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("show partition table: desc formatted should show partition type"){
    +    //check for partition type exist in desc formatted
    +    checkExistence(sql("describe formatted hashTable"),true,"Partition Type")
    +    val result: Array[Row] =sql("describe formatted hashTable").collect()
    --- End diff --
   
    add space after `=`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1689#discussion_r158573828
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala ---
    @@ -150,6 +150,14 @@ class TestShowPartition  extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("show partition table: desc formatted should show partition type"){
    +    //check for partition type exist in desc formatted
    +    checkExistence(sql("describe formatted hashTable"),true,"Partition Type")
    +    val result: Array[Row] =sql("describe formatted hashTable").collect()
    --- End diff --
   
    you can run this sql once and get result in Line 155


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2295/



---

[qiuchenjian-2]

Github user jatin9896 commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2538/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2296/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1080/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1689
 
   
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1689


---