[GitHub] carbondata pull request #1699: [CARBONDATA-1924] Restrict streaming on Parti...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/1699

    [CARBONDATA-1924] Restrict streaming on Partitioned table and support PARTITION syntax to the LOAD TABLE command

    Restrict streaming on Partitioned table and support PARTITION syntax to the LOAD TABLE command
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata partition-load-syntax

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1699
   
----
commit 88414667c29af37fca42d042997fb595bddf224f
Author: ravipesala <ravi.pesala@...>
Date:   2017-12-19T14:31:30Z

    Added PARTITION syntax to the LOAD TABLE

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1699#discussion_r158191780
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
    @@ -233,6 +233,9 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
           case _ =>
             // ignore this case
         }
    +    if (partitionFields.nonEmpty && options.isStreaming) {
    --- End diff --
   
    maybe it is better to do it in `validateStreamingProperty`, it is invoked in line 213


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1699
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/976/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1699
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2199/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1699
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2468/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1699#discussion_r158250930
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala ---
    @@ -233,6 +233,9 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
           case _ =>
             // ignore this case
         }
    +    if (partitionFields.nonEmpty && options.isStreaming) {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1699
 
    Datasource Create table using case also require similar validation. That can be handled in separate issue,  "support partitioning in Data source create table".


---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1699
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1699


---