[GitHub] carbondata pull request #1708: [CARBONDATA-1928] Seperate the properties for...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1708

    [CARBONDATA-1928] Seperate the properties for timeout and retries for load flow

    **Analysis:** Currently the property that is used to configure the lock retry count and the interval between retries is common for all the locks.
    This will be problematic when the user has configured the retries to 10/20 for concurrent loading. This property will be affecting other lock behaviours also, all other locks would have to retry for 10 times too.
   
    **Solution:**
    1. Change the name of the "carbon.load.metadata.lock.retries" property to "carbon.concurrent.lock.retries" AND "carbon.concurrent.lock.retry.timeout.sec"
    2. introduce a new property for all other locks
    "carbon.lock.retries" AND "carbon.lock.retry.timeout.sec"
   
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     Property change
     - [X] Any backward compatibility impacted?
     Yes
     - [X] Document update required?
    Yes
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata tablestatus_lock_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1708
   
----
commit 165d09312d501556b356b4dba660588fb79a8231
Author: kunal642 <kunalkapoor642@...>
Date:   2017-12-20T16:43:10Z

    seperate the properties for timeout and retries for load flow

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2252/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1029/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2508/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2256/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1033/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2510/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    LGTM


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1708#discussion_r158479473
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -573,23 +573,44 @@
       /**
        * NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK
        */
    -  public static final int NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK_DEFAULT = 3;
    +  public static final int NUMBER_OF_TRIES_FOR_CONCURRENT_LOCK_DEFAULT = 3;
    --- End diff --
   
    timeout check should be MAX_TIMEOUT_FOR_CONCURRENT_LOCK_DEFAULT = 1 sec,
    NUMBER_OF_TRIES_FOR_CONCURRENT_LOCK  = 100;
    also write comment why bigger number


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1708#discussion_r158479625
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -573,23 +573,44 @@
       /**
        * NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK
        */
    -  public static final int NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK_DEFAULT = 3;
    +  public static final int NUMBER_OF_TRIES_FOR_CONCURRENT_LOCK_DEFAULT = 3;
       /**
        * MAX_TIMEOUT_FOR_LOAD_METADATA_LOCK
        */
    -  public static final int MAX_TIMEOUT_FOR_LOAD_METADATA_LOCK_DEFAULT = 5;
    +  public static final int MAX_TIMEOUT_FOR_CONCURRENT_LOCK_DEFAULT = 5;
    --- End diff --
   
    rename to CONCURRENT_LOAD_LOCK


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2270/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1049/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1060/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1708
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1708


---