[GitHub] carbondata pull request #1710: [CARBONDATA-1930] Added condition to refer to...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1710

    [CARBONDATA-1930] Added condition to refer to parent dictionary if filter is given in aggregate table query

    **Analysis:** When filter is applied to aggregate query then the query is not accessing the parent table dictionary instead it is trying to search for aggregate table dictionary files.
   
    **Solution:** Add check to access parent table dictionary files if aggregate column has parent columns.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata aggregate_filter_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1710
   
----
commit 8b7570ba2f65c26b9e1ababb01905a907a0c7d00
Author: kunal642 <kunalkapoor642@...>
Date:   2017-12-22T07:53:11Z

    added condition to refer to parent dictionary if filter is given in aggregate table query

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2259/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1037/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1710#discussion_r158467171
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
    @@ -1241,15 +1243,28 @@ public static Dictionary getForwardDictionaryCache(
           AbsoluteTableIdentifier dictionarySourceAbsoluteTableIdentifier,
           CarbonDimension carbonDimension, TableProvider tableProvider) throws IOException {
         String dictionaryPath = null;
    +    ColumnIdentifier columnIdentifier = carbonDimension.getColumnIdentifier();
         if (null != tableProvider) {
           CarbonTable carbonTable = tableProvider
               .getCarbonTable(dictionarySourceAbsoluteTableIdentifier.getCarbonTableIdentifier());
           dictionaryPath = carbonTable.getTableInfo().getFactTable().getTableProperties()
               .get(CarbonCommonConstants.DICTIONARY_PATH);
    +      if (null != carbonDimension.getColumnSchema().getParentColumnTableRelations() &&
    --- End diff --
   
    here size check is also required when aggregate table is mapped to single parent column then only it will use table column dictionary otherwise it will use its own dictionary better to add a check size of parentcolumntablerelations is 1


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2516/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2268/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1047/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1710
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2521/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1710


---