[GitHub] carbondata pull request #1711: [CARBONDATA-1754][BugFix] Fixed issue occurin...

[qiuchenjian-2]

GitHub user SangeetaGulia opened a pull request:

    https://github.com/apache/carbondata/pull/1711

    [CARBONDATA-1754][BugFix] Fixed issue occuring on concurrent insert-overwrite and compaction

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? No
     
     - [x] Any backward compatibility impacted? No
     
     - [x] Document update required? No
   
     - [ x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
              Added test case to check its functionality. I have also tested this issue manually.
   
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A)
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1711
   
----
commit 963ff660c35764473d370d28b7494bc5135e2d44
Author: SangeetaGulia <sangeeta.gulia@...>
Date:   2017-12-21T13:12:18Z

    Fixed issue occuring on concurrent insert-overwrite and compaction

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1036/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2517/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2375/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1159/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Please describe what this bug is


---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    @jackylk I have added its description.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1711#discussion_r159035696
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala ---
    @@ -81,6 +84,13 @@ case class CarbonAlterTableCompactionCommand(
         carbonLoadModel.setDatabaseName(table.getDatabaseName)
         carbonLoadModel.setTablePath(table.getTablePath)
     
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(table)
    +    if (isLoadInProgress) {
    +      LOGGER.error("Cannot run data loading and compaction on same table concurrently. Please wait"
    --- End diff --
   
    please make a `val msg = "msg"`, then use it in both logger and exception, so that you do not need to put duplicated string


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1711#discussion_r159035783
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala ---
    @@ -81,6 +84,13 @@ case class CarbonAlterTableCompactionCommand(
         carbonLoadModel.setDatabaseName(table.getDatabaseName)
         carbonLoadModel.setTablePath(table.getTablePath)
     
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(table)
    --- End diff --
   
    why not do this check before line 78?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2623/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2624/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2442/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1222/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2534/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1309/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2698/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1711#discussion_r159816797
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala ---
    @@ -79,6 +81,14 @@ case class CarbonAlterTableCompactionCommand(
           relation.carbonTable
         }
     
    +    val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(table)
    +    if (isLoadInProgress) {
    +      val message = "Cannot run data loading and compaction on same table concurrently. " +
    +                    "Please wait for load to finish"
    +      LOGGER.error(message)
    +      throw new Exception(message)
    --- End diff --
   
    Better to create a new exception class for this kind of error, you can name it `ConcurrentOperationException`. We can use this in other similar places in the future.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2744/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1711
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2581/



---