Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1719: [CARBONDATA-1731,CARBONDATA-1728] Update fail...

Classic

List

Threaded

16 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1719: [CARBONDATA-1731,CARBONDATA-1728] Update fail...

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/1719

[CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error

[QueryExecution] Fetch BlockletId in Executor. Currently the granularâ¦These blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1731

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1719

----
commit 9b53188a57395ffecd99e33309df2b9b874a21ac
Author: anubhav100 <anubhav.tarar@...>
Date: 2017-12-14T07:24:08Z

Update fails incorrectly with error for table created in external db location

commit a9f64729fcecc4bea1e995a4bd187f4442a16e27
Author: anubhav100 <anubhav.tarar@...>
Date: 2017-12-22T12:23:26Z

[QueryExecution] Fetch BlockletId in Executor. Currently the granularâ¦These blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed
in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each
tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0.
Solution is to propagate the Blocklet IDs to the executor from driver

----

---

qiuchenjian-2

[GitHub] carbondata pull request #1719: [WIP] [CARBONDATA-1731,CARBONDATA-1728] Updat...

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1719#discussion_r158504977

--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java ---
@@ -113,10 +120,29 @@ public TableBlockInfo() {
public TableBlockInfo(String filePath, long blockOffset, String segmentId, String[] locations,
long blockLength, BlockletInfos blockletInfos, ColumnarFormatVersion version,
String[] deletedDeltaFilePath) {
- this(filePath, blockOffset, segmentId, locations, blockLength, version, deletedDeltaFilePath);
+ this(filePath, blockOffset, segmentId, locations, blockLength, version,
+ deletedDeltaFilePath);
this.blockletInfos = blockletInfos;
}

+ /**
+ * constructor to initialize the TbaleBlockInfo with blockletIds
+ *
+ * @param filePath
+ * @param blockOffset
+ * @param segmentId
+ * @param locations
+ * @param blockLength
+ * @param blockletInfos
+ */
+ public TableBlockInfo(String filePath, String blockletIds, long blockOffset, String segmentId,
--- End diff --

typo blockletId

---

qiuchenjian-2