GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/1745 [CARBONDATA-1955] Delta DataType calculation is incorrect for long type
**Problem**:
In case of Long type, the delta data type is always choosing the Long type.
But it should choose the datatype based on diff (max-min) of max and min values.
**Solution**:
Corrected to choose the delta data type based on max and min values.
- [X] Any interfaces changed?
NA
- [X] Any backward compatibility impacted?
**This issue must be synced to 1.2.0 branch**
- [X] Document update required?
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
Added unit test cases to test codec selection
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/mohammadshahidkhan/incubator-carbondata codecselectioncorrection_forlongtype_1.2.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1745.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit 1d9800c429afe28a4773183bdc3068fed63802ce
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date: 2017-12-30T00:52:48Z
[CARBONDATA-1955] Delta DataType calculation is incorrect for long type
----
---
Locked
