[GitHub] carbondata pull request #1756: [HOTFIX] Remove redundant object creation in ...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1756: [HOTFIX] Remove redundant object creation in ...

qiuchenjian-2
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1756

    [HOTFIX] Remove redundant object creation in writer

    There is an unnecessary object creation in writer, this PR removes it
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    No logic is modified, rerun all tests
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata patch-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1756
   
----
commit 276700d73e4d89b18c49e87cd55afe399d306606
Author: Jacky Li <jacky.likun@...>
Date:   2018-01-03T14:05:04Z

    remove redundant object creation

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1756: [HOTFIX] Remove unnecessary object creation in write...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1756
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1292/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1756: [HOTFIX] Remove unnecessary object creation in write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1756
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2522/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1756: [HOTFIX] Remove unnecessary object creation in write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1756
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2686/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1756: [HOTFIX] Remove unnecessary object creation in write...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1756
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1756: [HOTFIX] Remove unnecessary object creation i...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1756


---