[GitHub] carbondata pull request #1761: [CARBONDATA-1983] Remove unnecessary WriterVo...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1761

    [CARBONDATA-1983] Remove unnecessary WriterVo object

    There is an unnecessary WriterVo object created in writer, this PR removes it
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    No logic is modified
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata remove_writervo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1761
   
----
commit d0612944098a82e056435735e3f217207e630e44
Author: Jacky Li <jacky.likun@...>
Date:   2018-01-03T16:03:39Z

    remove WriterVo

commit 4d5e538da44cee1bd1f6cf762bf848a6297deefa
Author: Jacky Li <jacky.likun@...>
Date:   2018-01-04T08:14:13Z

    fix compile

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1761
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2539/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1761
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1310/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1761
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2707/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1761
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1761


---