[GitHub] carbondata pull request #1762: [CARBONDATA-1981][Build] Fix compile error in...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1762

    [CARBONDATA-1981][Build] Fix compile error in windows env

    # Scenario & RootCause
   
    PR #1738 introduced a way to generate version info while building project. It use bash script in maven, which will cause error in Windows environment.
   
    # Modification
   
    + Add `windows` profile to support building project in Windows
    environment. This profile is disabled by default.
   
    + If this profile is enabled, a Windows bat will be executed, otherwise a Unix bash script will be executed by default.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
             `No`
     - [X] Any backward compatibility impacted?
             `No`
     - [X] Document update required?
            `Yes. README in build module is updated`
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
             `No, not related`
            - How it is tested? Please attach test report.
             `Not related`
            - Is it a performance related change? Please attach the performance test report.
             `Not related`
            - Any additional information to help reviewers in testing this change.
             `No`
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
             `Not related`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata bug_windows_compile

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1762
   
----
commit 82f7b3d118d57a5916f8efe74798be8695598e13
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-01-04T09:21:56Z

    Fix compile error in windows env
   
    Add `windows` profile to support building project in Windows
    environment. This profile is disabled by default.

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2546/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1319/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2713/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2569/



---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1762#discussion_r159800564
 
    --- Diff: core/pom.xml ---
    @@ -114,24 +114,22 @@
         </resources>
         <plugins>
           <plugin>
    -        <groupId>org.apache.maven.plugins</groupId>
    -        <artifactId>maven-antrun-plugin</artifactId>
    -        <version>1.8</version>
    +        <groupId>org.codehaus.mojo</groupId>
    +        <artifactId>exec-maven-plugin</artifactId>
    +        <version>1.2.1</version>
             <executions>
               <execution>
                 <phase>generate-resources</phase>
    +            <!-- Execute the shell script to generate the CarbonData build information. -->
                 <configuration>
    -              <!-- Execute the shell script to generate the CarbonData build information. -->
    -              <target>
    -                <exec executable="bash">
    -                  <arg value="${project.basedir}/../build/carbondata-build-info"/>
    -                  <arg value="${project.build.directory}/extra-resources"/>
    -                  <arg value="${project.version}"/>
    -                </exec>
    -              </target>
    +              <executable>${project.basedir}/../build/carbondata-build-info${script.exetension}</executable>
    --- End diff --
   
    do it need to rename original 'carbondata-build-info' to 'carbondata-build-info.sh'?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2736/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1336/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1762#discussion_r159814603
 
    --- Diff: core/pom.xml ---
    @@ -114,24 +114,22 @@
         </resources>
         <plugins>
           <plugin>
    -        <groupId>org.apache.maven.plugins</groupId>
    -        <artifactId>maven-antrun-plugin</artifactId>
    -        <version>1.8</version>
    +        <groupId>org.codehaus.mojo</groupId>
    +        <artifactId>exec-maven-plugin</artifactId>
    +        <version>1.2.1</version>
             <executions>
               <execution>
                 <phase>generate-resources</phase>
    +            <!-- Execute the shell script to generate the CarbonData build information. -->
                 <configuration>
    -              <!-- Execute the shell script to generate the CarbonData build information. -->
    -              <target>
    -                <exec executable="bash">
    -                  <arg value="${project.basedir}/../build/carbondata-build-info"/>
    -                  <arg value="${project.build.directory}/extra-resources"/>
    -                  <arg value="${project.version}"/>
    -                </exec>
    -              </target>
    +              <executable>${project.basedir}/../build/carbondata-build-info${script.exetension}</executable>
    --- End diff --
   
    In *nix & Windows environment, maven will execute different scripts, so we need to rename the file.


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    @zzcclp , do you know how to handle the following `Permission denied` error?
   
    [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (default) on project carbondata-core: Command execution failed. Cannot run program "/var/lib/jenkins/workspace/ApacheCarbonPRBuilder/core/../build/carbondata-build-info.sh" (in directory "/var/lib/jenkins/workspace/ApacheCarbonPRBuilder/core"): error=13, Permission denied -> [Help 1]


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    @xuchuanyin when rename carbondata-build-info to carbondata-build-info.sh, the permission of it had been changed 755 to 644? so it is permission denied. you can try to chmod arbondata-build-info.sh to 755 and re-commit.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2742/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1346/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2587/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1352/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1370/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1762
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2605/



---