[GitHub] carbondata pull request #1763: [CARBONDATA-1984] Double Compression Codec Re...

[qiuchenjian-2]

GitHub user sounakr opened a pull request:

    https://github.com/apache/carbondata/pull/1763

    [CARBONDATA-1984] Double Compression Codec Rectification.

   
    Double datatype compression done through AdaptiveFloatingDelta AdaptiveFloating codec is not returning expected output. These two codec for double compression multiple double with another double. Double multipled with double doesnt give exact output, 1.2 ie one-and-one-fifth can't be exactly represented as a binary fraction. You get close with one-and-an-eigth-and-a-sixteenth.... but never exactly one-fifth.
   
    So due to the multiply and substract to encode the data, there are some loss of precision and we give a different output when encoded.
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done Yes
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sounakr/incubator-carbondata double_datatype_roundoff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1763
   
----
commit 6ede959fef92c017818755e6be311b0794e3566d
Author: sounakr <sounakr@...>
Date:   2018-01-04T09:45:42Z

    [CARBONDATA-1984] Double Compression Codec Rectification. Use RoundUp in case double is multipled with double to get consistant result.

----


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1763#discussion_r159640432
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala ---
    @@ -1154,4 +1154,114 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("Double Datatype Check with AdaptiveDeltaFloating Codec (BYTE)") {
    --- End diff --
   
    Move these tests to new suite


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2545/



---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1763#discussion_r159649771
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala ---
    @@ -1154,4 +1154,114 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
     
       }
     
    +  test("Double Datatype Check with AdaptiveDeltaFloating Codec (BYTE)") {
    --- End diff --
   
    Done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1318/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2555/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2719/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2725/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1763
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1763


---