[GitHub] carbondata pull request #1767: [CARBONDATA-1993] Carbon properties default v...

[qiuchenjian-2]

GitHub user pawanmalwal opened a pull request:

    https://github.com/apache/carbondata/pull/1767

    [CARBONDATA-1993] Carbon properties default values fix and correspond…

    Carbon properties default values fix and corresponding template and document correction.
   
     - [X] Any interfaces changed?
     None
     - [X] Any backward compatibility impacted?
     None
     - [X] Document update required?
    Updated corresponding template and document
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           None
   
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    None

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pawanmalwal/carbondata carbon_properties_default_value_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1767
   
----
commit 72f4ebbf6ae06b0472990bd4d60704af697febef
Author: Pawan Malwal <pmalwal1981@...>
Date:   2018-01-05T15:56:15Z

    [CARBONDATA-1993] Carbon properties default values fix and corresponding and template, document correction.

----


---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1767#discussion_r159920010
 
    --- Diff: conf/carbon.properties.template ---
    @@ -20,7 +20,7 @@
     #Mandatory. Carbon Store path
     carbon.storelocation=hdfs://hacluster/Opt/CarbonStore
     #Base directory for Data files
    -carbon.ddl.base.hdfs.url=hdfs://hacluster/opt/data
    +carbon.ddl.base.hdfs.url=
    --- End diff --
   
    If the default value is empty, shall we remove property from template or just comment out and keep ?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1767
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1356/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1767
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2596/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1767
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2760/



---

[qiuchenjian-2]

Github user pawanmalwal commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1767#discussion_r160114212
 
    --- Diff: conf/carbon.properties.template ---
    @@ -20,7 +20,7 @@
     #Mandatory. Carbon Store path
     carbon.storelocation=hdfs://hacluster/Opt/CarbonStore
     #Base directory for Data files
    -carbon.ddl.base.hdfs.url=hdfs://hacluster/opt/data
    +carbon.ddl.base.hdfs.url=
    --- End diff --
   
    I have commented it for now.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1767
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2637/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1767
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2643/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1767#discussion_r160874806
 
    --- Diff: conf/carbon.properties.template ---
    @@ -29,11 +29,11 @@ carbon.badRecords.location=/opt/Carbon/Spark/badrecords
     #File read buffer size used during sorting(in MB) :MIN=1:MAX=100
     carbon.sort.file.buffer.size=20
     #Rowset size exchanged between data load graph steps :MIN=500:MAX=1000000
    -carbon.graph.rowset.size=100000
    +carbon.graph.rowset.size=500
    --- End diff --
   
    Remove from property template and from idg also if present.


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1767#discussion_r160875218
 
    --- Diff: conf/carbon.properties.template ---
    @@ -20,7 +20,7 @@
     #Mandatory. Carbon Store path
     carbon.storelocation=hdfs://hacluster/Opt/CarbonStore
    --- End diff --
   
    In code we dont have default value for carbon.storelocation, so better to remove it.


---

[qiuchenjian-2]

Github user pawanmalwal closed the pull request at:

    https://github.com/apache/carbondata/pull/1767


---