[GitHub] carbondata pull request #1806: modify default config: change the default of ...

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1806: modify default config: change the default of ...

qiuchenjian-2
GitHub user qiuchenjian opened a pull request:

    https://github.com/apache/carbondata/pull/1806

    modify default config: change the default of tempCSV to false

    qiuchenjian
   
        tempCSV model generates file to hdfs and then generate sql "load data" ,it depends much time. So , the default value of tempCSV should be false.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qiuchenjian/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1806.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1806
   
----
commit fb7f72ec3413047c1edda1705d84ccf0d913353e
Author: qiuchenjian <807169000@...>
Date:   2018-01-15T14:47:24Z

    modify default config: change the default of tempCSV to false
    qiuchenjian

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Can one of the admins verify this patch?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Can one of the admins verify this patch?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Can one of the admins verify this patch?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Please create a JIRA issue and add it to the title of the PR. Thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    add to whitelist


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1691/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2924/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2960/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1779/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3009/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3021/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1806
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1806: modify default config: change the default of ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1806


---