Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1809: [CARBONDATA-2031] Fix ArrayIndexOutOfBoundExc...

Classic

List

Threaded

17 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1809: [CARBONDATA-2031] Fix ArrayIndexOutOfBoundExc...

GitHub user akashrn5 opened a pull request:

https://github.com/apache/carbondata/pull/1809

[CARBONDATA-2031] Fix ArrayIndexOutOfBoundException when filter query is applied on column where all values are null and column is noinverted index column

PROBLEM:
Fix ArrayIndexOutOfBoundException when filter query is applied on column where all values are null and column is noinverted index column

when all the values are null in no inverted index column the number of exclude filter keys are null, hence just return the bitset if the exclude filters to be applied are none.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [X] Any interfaces changed?
NA
- [X] Any backward compatibility impacted?
NA
- [X] Document update required?
NA
- [X] Testing done
UT is added
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akashrn5/incubator-carbondata AIOB

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1809

----
commit 6eec40e7c9cc82174e3beaf451a74fb86c4d84da
Author: akashrn5 <akashnilugal@...>
Date: 2018-01-16T06:47:53Z

Fix ArrayIndexOutOfBoundException when filter query is applied on column where all values are null and column is noinverted index column

----

---

qiuchenjian-2

[GitHub] carbondata pull request #1809: [CARBONDATA-2031] Fix ArrayIndexOutOfBoundExc...

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1809#discussion_r161676396

--- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java ---
@@ -378,6 +378,9 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
BitSet bitSet = new BitSet(numerOfRows);
bitSet.flip(0, numerOfRows);
byte[][] filterValues = dimColumnExecuterInfo.getExcludeFilterKeys();
+ if (filterValues.length == 0) {
--- End diff --

Please add comment for both Include and exclude when filter can be null

---

qiuchenjian-2